From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LjsoS-0003LG-46 for mharc-grub-devel@gnu.org; Wed, 18 Mar 2009 06:15:52 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LjsoQ-0003JF-Ee for grub-devel@gnu.org; Wed, 18 Mar 2009 06:15:50 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LjsoL-0003FF-Ln for grub-devel@gnu.org; Wed, 18 Mar 2009 06:15:49 -0400 Received: from [199.232.76.173] (port=45775 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LjsoL-0003FB-GQ for grub-devel@gnu.org; Wed, 18 Mar 2009 06:15:45 -0400 Received: from aybabtu.com ([69.60.117.155]:40066) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LjsoL-0004JG-4v for grub-devel@gnu.org; Wed, 18 Mar 2009 06:15:45 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1LjsfQ-0008Mf-NK for grub-devel@gnu.org; Wed, 18 Mar 2009 11:06:33 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1LjsoI-0005Fx-D2 for grub-devel@gnu.org; Wed, 18 Mar 2009 11:15:42 +0100 Date: Wed, 18 Mar 2009 11:15:42 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090318101542.GC20072@thorin> References: <20090315154002.GC24554@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] patch to compile grub2 in msys/mingw environment X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Mar 2009 10:15:50 -0000 On Tue, Mar 17, 2009 at 01:54:22PM +0800, Bean wrote: > > > > It seems you defined the mingw32 version of grub_millisleep unconditionally. > > Hi, > > Are you suggesting adding some test in configure.ac ? Although > grub_millisleep for mingw32 uses Windows API Sleep, I guess it's safe > to assume it's present. I just meant that when __MINGW32__ is not defined, the function is implemented twice: > +#ifndef __MINGW32__ > void > grub_millisleep (grub_uint32_t ms) > { > @@ -320,6 +321,7 @@ grub_millisleep (grub_uint32_t ms) > ts.tv_nsec = (ms % 1000) * 1000000; > nanosleep (&ts, NULL); > } > +#endif > > void > grub_arch_sync_caches (void *address __attribute__ ((unused)), > @@ -361,6 +363,12 @@ void sleep (int s) > Sleep (s * 1000); > } > > +void > +grub_millisleep (grub_uint32_t ms) > +{ > + Sleep (ms); > +} > + why not put them together anyway? Like #ifdef __MINGW32__ ... #else ... #endif -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."