All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luis Henriques <henrix@sapo.pt>
To: Gregory Haskins <ghaskins@novell.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -tip] sched: Clean unused fields from struct rq
Date: Wed, 18 Mar 2009 21:52:24 +0000	[thread overview]
Message-ID: <20090318215224.GA8030@hades.domain.com> (raw)
In-Reply-To: <49C160D6.6010409@novell.com>

Hi,
On Wed, Mar 18, 2009 at 05:00:06PM -0400, Gregory Haskins wrote:
> I actually key off the SCHEDSTAT_VERSION (currently 14) at the top of
> kernel/sched_stats.h.  Cursory inspection of the existing code and your
> patch says that this should actually be the value that needs updating
> (vs. vSched-Debug).  However, note that I am not sure if there are also
> users of sched-debug that need to see that version bump as well in order
> to remain compatible.

Just realised something while taking a look at you're schedtop: you are
referring to sched_stats, which shows data in /proc/schedstat, while my patch
actually targets sched_debug, which shows data in /proc/sched_debug.  And I
guess this is why we have 2 different versioning mechanisms:  they refer to
different things :-)

So, if this is correct, my last patch actually updates the correct version,
right?

Regards,
-- 
Luis Henriques

  parent reply	other threads:[~2009-03-18 21:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-18 20:28 [PATCH -tip] sched: Clean unused fields from struct rq Luis Henriques
2009-03-18 21:00 ` Gregory Haskins
2009-03-18 21:20   ` Luis Henriques
2009-03-18 21:52   ` Luis Henriques [this message]
2009-03-18 22:07     ` Luis Henriques

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090318215224.GA8030@hades.domain.com \
    --to=henrix@sapo.pt \
    --cc=ghaskins@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.