All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/8 v2] UBIFS: Implement read-only UBIFS support in U-Boot (Part 1)
Date: Thu, 19 Mar 2009 10:27:54 +0100	[thread overview]
Message-ID: <200903191027.54334.sr@denx.de> (raw)
In-Reply-To: <20090318200903.F2788832E8B7@gemini.denx.de>

Hi Wolfgang,

On Wednesday 18 March 2009, Wolfgang Denk wrote:
> > This patchset adds UBIFS read-only support to U-Boot. The following
> > commands are implemented:
> >
> > - ubifsmount
> >   Mount an UBIFS volume
> >
> > - ubifsls
> >   List a directory of the mounted UBIFS volume
> >
> > - ubifsload
> >   Load a file from the mounted UBIFS volume to memory
> >
> > The U-Boot UBIFS implementation is largely a direct copy from the current
> > Linux version (2.6.29-rc6). As already done in the UBI version we have an
> > "abstraction layer" to redefine or remove some OS calls (e.g.
> > mutex_lock() ...). This makes it possible to use the original Linux code
> > with very little changes. And by this we can better update to later Linux
> > versions.
> >
> > I removed some of the Linux features that are not used in the U-Boot
> > version (e.g. garbage-collection, write support).
> >
> > Signed-off-by: Stefan Roese <sr@denx.de>
> > CC: Artem Bityutskiy <dedekind@infradead.org>
> > CC: Adrian Hunter <ext-Adrian.Hunter@nokia.com>
>
> I don't understand the split of this patchset into 8 patches, which
> all use the very same subject (= commit title line) and commit
> message.
>
> It seems the splitting was done just for size reasons, not taking into
> account any logic parts that belong together or bi-sectability.

Correct. Even though it should still be git bisectable.

> Please explain why this is not just a single commit?

Sure. It's the list limit. It was my understanding that patches > 100k usually 
are not accepted on the list. This UBIFS support is approx. 500k in total, so 
I didn't even try to send it as a single patch.

OK, I'll send the patch to list again in a short while.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

      reply	other threads:[~2009-03-19  9:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-12 13:55 [U-Boot] [PATCH 1/8 v2] UBIFS: Implement read-only UBIFS support in U-Boot (Part 1) Stefan Roese
2009-03-18 20:09 ` Wolfgang Denk
2009-03-19  9:27   ` Stefan Roese [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200903191027.54334.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.