From: Jamie Lokier <jamie@shareable.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [patch 1/7] qemu: mutex/thread/cond wrappers
Date: Thu, 19 Mar 2009 18:49:03 +0000 [thread overview]
Message-ID: <20090319184903.GA7631@shareable.org> (raw)
In-Reply-To: <49C26BE9.4030905@redhat.com>
Avi Kivity wrote:
> >+int qemu_mutex_init(QemuMutex *mutex)
> >+{
> >+ return pthread_mutex_init(&mutex->lock, NULL);
> >+}
>
> No one will check the return code, so better to check it here and
> abort() if it's bad.
I agree.
Same applies to pthread_mutex_lock, etc., all of which return an error
code, can fail if misused, and nobody checks.
-- Jamie
next prev parent reply other threads:[~2009-03-19 18:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-19 14:57 [Qemu-devel] [patch 0/7] separate thread for io v2 mtosatti
2009-03-19 14:57 ` [Qemu-devel] [patch 1/7] qemu: mutex/thread/cond wrappers mtosatti
2009-03-19 15:59 ` Avi Kivity
2009-03-19 18:49 ` Jamie Lokier [this message]
2009-03-23 23:17 ` Marcelo Tosatti
2009-03-24 7:43 ` Avi Kivity
2009-03-19 14:57 ` [Qemu-devel] [patch 2/7] qemu: separate thread for io mtosatti
2009-03-20 17:43 ` [Qemu-devel] " Anthony Liguori
2009-03-21 0:06 ` Marcelo Tosatti
2009-03-21 1:04 ` Anthony Liguori
2009-03-21 1:44 ` Marcelo Tosatti
2009-03-21 1:50 ` Anthony Liguori
2009-03-22 8:48 ` Avi Kivity
2009-03-22 11:17 ` Anthony Liguori
2009-03-19 14:57 ` [Qemu-devel] [patch 3/7] qemu: main thread does io and cpu thread is spawned mtosatti
2009-03-19 14:57 ` [Qemu-devel] [patch 4/7] qemu: handle reset/poweroff/shutdown in iothread mtosatti
2009-03-19 14:57 ` [Qemu-devel] [patch 5/7] qemu: pause and resume cpu thread(s) mtosatti
2009-03-19 14:57 ` [Qemu-devel] [patch 6/7] qemu: handle vmstop from cpu context mtosatti
2009-03-19 14:57 ` [Qemu-devel] [patch 7/7] qemu: use pipe to wakeup io thread mtosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090319184903.GA7631@shareable.org \
--to=jamie@shareable.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.