From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2: Fix 2 warning during ocfs2 make.
Date: Thu, 19 Mar 2009 15:06:37 -0700 [thread overview]
Message-ID: <20090319220637.GA18943@mail.oracle.com> (raw)
In-Reply-To: <49C1EA90.6090201@oracle.com>
On Thu, Mar 19, 2009 at 02:47:44PM +0800, Wengang Wang wrote:
> yes, that's the problem.
> we'd better unify the different types(but could be another patch).
> since the on disk is u16, modifying other types to u16 is fine :)
The -1 is a special value, and it isn't always a u16 we're
talking about. This is both historical code and on-disk values.
INVALID_SLOT isn't 65535, it's -1. You have to have the comparisons as
they currently stand, with the casts.
Joel
--
"Any man who is under 30, and is not a liberal, has not heart;
and any man who is over 30, and is not a conservative, has no brains."
- Sir Winston Churchill
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2009-03-19 22:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-18 21:08 [Ocfs2-devel] [PATCH] ocfs2: Fix 2 warning during ocfs2 make Tao Ma
2009-03-19 6:28 ` Wengang Wang
2009-03-19 6:31 ` Wengang Wang
2009-03-19 6:42 ` Tao Ma
2009-03-19 6:47 ` Wengang Wang
2009-03-19 22:06 ` Joel Becker [this message]
2009-03-19 22:07 ` Joel Becker
2009-03-20 0:38 ` Mark Fasheh
2009-03-20 0:45 ` Tao Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090319220637.GA18943@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.