From: "Shawn O. Pearce" <spearce@spearce.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>, Petr Baudis <pasky@suse.cz>,
Andreas Gruenbacher <agruen@suse.de>,
git@vger.kernel.org
Subject: Re: ref name troubles, was Re: [PATCH v2] Introduce %<branch> as shortcut to the tracked branch
Date: Thu, 19 Mar 2009 17:44:50 -0700 [thread overview]
Message-ID: <20090320004450.GY23521@spearce.org> (raw)
In-Reply-To: <20090320004029.GX23521@spearce.org>
"Shawn O. Pearce" <spearce@spearce.org> wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> > On Fri, 20 Mar 2009, Johannes Schindelin wrote:
> >
> > > Just try this:
> > >
> > > $ git checkout -b %helloworld
> >
> > It gets worse. Much worse.
> >
> > Try this (triggered by a comment by Ilari on IRC):
> >
> > $ git checkout -b '@{1}'
> >
> > That _works_! WTH?
>
> '@' is not reserved. Neither is '{' or '}'. Neither is
> the combination.
In hindsight, I wish we had reserved all of the "fun" characters
like !@#$%^&*():;~'"\ and prevented them from ever appearing in a
ref name.
Instead only what check_ref_format() in refs.c ll.694 tells is
is reserved:
671 /*
672 * Make sure "ref" is something reasonable to have under ".git/refs/";
673 * We do not like it if:
674 *
675 * - any path component of it begins with ".", or
676 * - it has double dots "..", or
677 * - it has ASCII control character, "~", "^", ":" or SP, anywhere, or
678 * - it ends with a "/".
679 */
Heh. At least : and SP are reserved.
Use BEL for your %helloworld hack. It'll be fun to type. :-)
--
Shawn.
next prev parent reply other threads:[~2009-03-20 0:46 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200903181448.50706.agruen@suse.de>
2009-03-18 18:26 ` Git {log,diff} against tracked branch? Petr Baudis
2009-03-18 21:12 ` [PATCH] Introduce %<branch> as shortcut to the tracked branch Johannes Schindelin
2009-03-18 21:41 ` Andreas Gruenbacher
2009-03-18 21:46 ` [PATCH v2] " Johannes Schindelin
2009-03-18 21:58 ` Andreas Gruenbacher
2009-03-18 22:43 ` Johannes Schindelin
2009-03-18 22:34 ` Junio C Hamano
2009-03-18 22:46 ` Johannes Schindelin
2009-03-19 14:52 ` Michael J Gruber
2009-03-19 15:17 ` Michael J Gruber
2009-03-20 0:23 ` Johannes Schindelin
2009-03-20 0:38 ` ref name troubles, was " Johannes Schindelin
2009-03-20 0:40 ` Shawn O. Pearce
2009-03-20 0:44 ` Shawn O. Pearce [this message]
2009-03-20 5:59 ` Sverre Rabbelier
2009-03-20 9:29 ` [PATCH v3] Introduce BEL<branch> " Johannes Schindelin
2009-03-20 9:42 ` Wincent Colaiuta
2009-03-20 9:54 ` Johannes Schindelin
2009-03-20 12:33 ` Santi Béjar
2009-03-20 12:45 ` Andreas Gruenbacher
2009-03-20 13:05 ` Matthieu Moy
2009-03-20 12:46 ` Johannes Schindelin
2009-03-20 12:53 ` Mikael Magnusson
2009-03-20 14:00 ` Johannes Schindelin
2009-03-20 10:04 ` [PATCH] Document and test the new % shotcut for " Michael J Gruber
2009-03-20 10:31 ` Johannes Schindelin
2009-03-20 10:38 ` Michael J Gruber
2009-03-20 11:16 ` Petr Baudis
2009-03-20 11:48 ` Johannes Schindelin
2009-03-22 17:40 ` Petr Baudis
2009-03-20 14:15 ` Michael J Gruber
2009-03-20 16:17 ` [PATCH v4] Introduce %<branch> as shortcut to " Johannes Schindelin
2009-03-20 17:03 ` Junio C Hamano
2009-03-20 17:32 ` Johannes Schindelin
2009-03-20 18:02 ` Junio C Hamano
2009-03-20 19:36 ` Jeff King
2009-03-20 20:28 ` Julian Phillips
2009-03-20 20:50 ` Jeff King
2009-03-20 23:08 ` Julian Phillips
2009-03-20 23:20 ` Sverre Rabbelier
2009-03-20 23:41 ` Julian Phillips
2009-03-20 23:45 ` Sverre Rabbelier
2009-03-21 0:35 ` Andreas Gruenbacher
2009-03-21 1:10 ` Miles Bader
2009-03-21 13:24 ` Julian Phillips
2009-03-21 13:28 ` Julian Phillips
2009-03-20 17:08 ` Björn Steinbrink
2009-03-20 6:05 ` ref name troubles, was Re: [PATCH v2] " Jeff King
2009-03-20 6:57 ` Junio C Hamano
2009-03-20 9:30 ` Johannes Schindelin
2009-03-20 11:12 ` Petr Baudis
2009-03-20 11:46 ` Johannes Schindelin
2009-03-20 11:50 ` Petr Baudis
2009-03-20 11:57 ` Johannes Schindelin
2009-03-20 14:31 ` Michael J Gruber
2009-03-20 15:01 ` Johannes Schindelin
2009-03-20 15:12 ` Michael J Gruber
2009-03-20 16:47 ` Junio C Hamano
2009-03-20 19:34 ` Daniel Barkalow
2009-03-20 21:48 ` Johannes Schindelin
2009-03-21 21:00 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090320004450.GY23521@spearce.org \
--to=spearce@spearce.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=agruen@suse.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.