From: Ingo Molnar <mingo@elte.hu>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"hpa@zytor.com" <hpa@zytor.com>,
"markus.t.metzger@gmail.com" <markus.t.metzger@gmail.com>,
"roland@redhat.com" <roland@redhat.com>,
"eranian@googlemail.com" <eranian@googlemail.com>,
"oleg@redhat.com" <oleg@redhat.com>,
"Villacis, Juan" <juan.villacis@intel.com>,
"ak@linux.jf.intel.com" <ak@linux.jf.intel.com>
Subject: Re: [patch] x86, bts: use atomic memory allocation
Date: Fri, 20 Mar 2009 19:55:59 +0100 [thread overview]
Message-ID: <20090320185559.GA6224@elte.hu> (raw)
In-Reply-To: <928CFBE8E7CB0040959E56B4EA41A77E923FFCA4@irsmsx504.ger.corp.intel.com>
* Metzger, Markus T <markus.t.metzger@intel.com> wrote:
> >-----Original Message-----
> >From: Ingo Molnar [mailto:mingo@elte.hu]
> >Sent: Thursday, March 19, 2009 5:12 PM
> >To: Metzger, Markus T
>
>
> >> Ds_request_bts() needs to allocate memory. It uses GFP_KERNEL.
> >>
> >> Hw-branch-tracer calls ds_request_bts() within on_each_cpu().
> >>
> >> Use atomic memory allocation to allow it to be used in that context.
> >
> >the hw-branch-tracer still crashes during bootup. Have you tried the
> >config i sent to you, and have you tried to reproduce it? I've
> >attached another config that crashes.
>
> The first config boots OK.
> The second config boots OK with the additional changes to keep the
> GFP_KERNEL and move the ds_request_bts() calls out of the
> on_each_cpu() in the hw-branch-tracer.
>
> I don't know yet what exactly causes the crash and if there is a
> simpler fix.
hm, this was an AMD box - so perhaps they dont have a compatible DS
implementation?
Ingo
next prev parent reply other threads:[~2009-03-20 18:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-18 18:27 [patch] x86, bts: use atomic memory allocation Markus Metzger
2009-03-19 16:11 ` Ingo Molnar
2009-03-20 8:07 ` Metzger, Markus T
2009-03-20 8:37 ` Andi Kleen
2009-03-20 16:23 ` Metzger, Markus T
2009-03-20 18:55 ` Ingo Molnar [this message]
2009-03-20 18:59 ` Markus Metzger
2009-03-25 9:07 ` Metzger, Markus T
2009-05-07 9:21 ` [tip:tracing/core] " tip-bot for Markus Metzger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090320185559.GA6224@elte.hu \
--to=mingo@elte.hu \
--cc=ak@linux.jf.intel.com \
--cc=eranian@googlemail.com \
--cc=hpa@zytor.com \
--cc=juan.villacis@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.t.metzger@gmail.com \
--cc=markus.t.metzger@intel.com \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.