From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [RFC v14-rc][PATCH 07/23] Restore memory address space Date: Fri, 20 Mar 2009 18:54:33 -0500 Message-ID: <20090320235433.GA19565@us.ibm.com> References: <1237574868-3371-1-git-send-email-orenl@cs.columbia.edu> <1237574868-3371-8-git-send-email-orenl@cs.columbia.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1237574868-3371-8-git-send-email-orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Oren Laadan Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Dave Hansen List-Id: containers.vger.kernel.org Quoting Oren Laadan (orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org): > + ret = -EINVAL; > + if (hh->vdso != (unsigned long) mm->context.vdso) > + goto out; We were just talking about vdso+s390 on irc this morning, wondering about how to handle it... Looking at arch/x86/vdso/vma.c, this seems like it should pretty much always error out. The vdso base is set as a random offset above the stack base at exec(). -serge