Re: [RFC][PATCH 4/5] ar9170: USB frontend driver

[Michael Buesch <mb@bu3sch.de>]

On Saturday 21 March 2009 12:10:35 Johannes Berg wrote:
> On Fri, 2009-03-20 at 20:58 +0100, Michael Buesch wrote:
> > On Friday 20 March 2009 20:36:42 Christian Lamparter wrote:
> > > USB frontend driver code for Atheros AR9170.
> > 
> > It seems lots of patches didn't make it through the list. :(
> > 
> > > +#if 0
> > > +#include <linux/mutex.h>
> > > +#define mutex_lock(m) do { mutex_lock(m); __acquire(m); } while (0)
> > > +#define mutex_unlock(m) do { mutex_unlock(m); __release(m); } while (0)
> > > +#endif
> > > +
> > > +#endif /* __USB_H */
> > 
> > Whoops, debugging code? :)
> 
> sparse, for some reason mutex operations aren't annotated... Probably
> because Ingo wrote the code...

Well I think it would currently generate lots of errors, because we have
code like this in the kernel:

if (x)
	mutex_lock();
...
if (x)
	mutex_unlock();

-- 
Greetings, Michael.