From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LlO02-0000Oj-5Q for mharc-grub-devel@gnu.org; Sun, 22 Mar 2009 09:46:02 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LlO00-0000OM-TF for grub-devel@gnu.org; Sun, 22 Mar 2009 09:46:01 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LlNzw-0000Mh-BD for grub-devel@gnu.org; Sun, 22 Mar 2009 09:46:00 -0400 Received: from [199.232.76.173] (port=41479 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LlNzv-0000MX-VS for grub-devel@gnu.org; Sun, 22 Mar 2009 09:45:56 -0400 Received: from aybabtu.com ([69.60.117.155]:49919) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LlNzv-00057o-MV for grub-devel@gnu.org; Sun, 22 Mar 2009 09:45:55 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1LlNqb-0004SM-KV for grub-devel@gnu.org; Sun, 22 Mar 2009 14:36:18 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1LlNzs-0001uQ-1V for grub-devel@gnu.org; Sun, 22 Mar 2009 14:45:52 +0100 Date: Sun, 22 Mar 2009 14:45:52 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090322134551.GA7324@thorin> References: <49B52C12.5080105@gmail.com> <49C638A0.3060506@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49C638A0.3060506@gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Leak fixes X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Mar 2009 13:46:01 -0000 On Sun, Mar 22, 2009 at 02:09:52PM +0100, phcoder wrote: > > - grub_disk_cache_invalidate (dev_id, disk_id, sector); > - > index = grub_disk_cache_get_index (dev_id, disk_id, sector); > cache = grub_disk_cache_table + index; > + > + cache->lock = 1; > + grub_free (cache->data); > + cache->data = 0; > + cache->lock = 0; Does this imply grub_disk_cache_invalidate() is not working properly? Can it be fixed instead? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."