From: Ingo Molnar <mingo@elte.hu>
To: Tom Zanussi <tzanussi@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Frédéric Weisbecker" <fweisbec@gmail.com>
Subject: Re: [PATCH 0/4] tracing: event filtering v2
Date: Sun, 22 Mar 2009 20:56:24 +0100 [thread overview]
Message-ID: <20090322195624.GC15002@elte.hu> (raw)
In-Reply-To: <1237710626.7703.45.camel@charm-linux>
* Tom Zanussi <tzanussi@gmail.com> wrote:
> Hi,
>
> This is version 2 of my patchset adding filtering to the
> event-tracing infrastructure.
>
> Changes from the previous version:
>
> - added common_ prefix to the 5 common event fields
> - ring_buffer_event_discard() fixes from Steven Rostedt
> - changed 'and' and 'or' for compound filters to '&&' and '||'
> - fixed a bug in the matching logic
>
> Everything seems to work ok for me, but I haven't yet gotten
> around to changing the awkward UI. I plan to fix that as soon as
> I can i.e. allow complete compound expressions to be specified all
> at once, add <, >, <=, >= and parens, etc. Until then, it should
> hopefully be usable for basic filtering.
Thanks Tom - Frederic and me had a good look and i picked them up
into tip:tracing/filters for now and lets see how they hold up in
testing. There was one boundary-condition bug Frederic noticed, i
fixed that.
The subsystem level filters are a nice touch. We still have to
complete and organize events into a comprehensive, Linux-wide set of
tracepoints, so there will be some churn in this area.
Ingo
next prev parent reply other threads:[~2009-03-22 19:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-22 8:30 [PATCH 0/4] tracing: event filtering v2 Tom Zanussi
2009-03-22 19:56 ` Ingo Molnar [this message]
2009-03-23 8:29 ` Tom Zanussi
2009-03-22 23:06 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090322195624.GC15002@elte.hu \
--to=mingo@elte.hu \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.