From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryusuke Konishi Subject: Re: Constant checkpointing and cleanerd activity - doesn't play nice with mount --bind ? Date: Mon, 23 Mar 2009 02:53:19 +0900 (JST) Message-ID: <20090323.025319.46709946.ryusuke@osrg.net> References: <20090317154529.1aeeecdc@natsu.i4> <20090317.224324.58871500.ryusuke@osrg.net> <20090317191924.1924576b@natsu.i4> Reply-To: NILFS Users mailing list Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090317191924.1924576b-2Ve/5xEMxL0@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: users-bounces-JrjvKiOkagjYtjvyW6yDsg@public.gmane.org Errors-To: users-bounces-JrjvKiOkagjYtjvyW6yDsg@public.gmane.org To: roman-ohbefDXYbNo@public.gmane.org Cc: users-JrjvKiOkagjYtjvyW6yDsg@public.gmane.org On Tue, 17 Mar 2009 19:19:24 +0500, Roman Mamedov wrote: > On Tue, 17 Mar 2009 22:43:24 +0900 (JST) > Ryusuke Konishi wrote: > > > The garbage collection of nilfs is ``copying GC'', and it creates > > checkpoints (it's normal for nilfs). In addition, if segments > > selected for cleaning have few reclaimable blocks, most remaining > > blocks are copied into new segments. > > I thought the NBLKINC count should not increase much when there are > no user writes to the filesystem. But it was increasing by several > thousands on every step. Uum, sound logical. But the interpretation will fairly change the semantics and require some clarification about what the increment is supposed to be: - blocks duplicated for copy-on-write --> should be treated as increments (maybe) - Segment headers and super root block. --> treated as increment at present (should be removed for the above standpoint) - Some nilfs meta data files like sufile, cpfile, and the DAT file. --> treated as increment at present. These files even do not have past versions. So, they slightly differ from regular files in that sense. Fortunately, this value does not affect FS-internal operation nor cleanerd. Only lscp uses the field. So, it could be changed if no one disputes it. > This filesystem has size of about 300 gigabytes, and all I did, is > copied about 150 gigabytes of data to it, with no deletions, no > modifications or rewrites. But even about 6-8 hours after that, the > cleanerd process still has work to do, so much, that it interferes with > normal usage of the filesystem (i.e. playing a FLAC audio file from it > was skipping at times, even counting a bit increased load from going > through kcryptd, this shouldn't happen). Sorry. The current cleanerd is far from intelligent as you pointed out, and I feel the same about that. One of my colleagues is recently trying to improve the cleanerd behavior. > > Did you specify an fstype option? > > I had the fstype specified as "none" (in fstab). > > > /nilfs2 on /test type none (rw,bind) > > Yes, this is what I have. > > > and, the second cleanerd has gone: > > I have only one cleanderd in process list. > > What is really strange, is that it looks like I can unmount the main > NILFS, but the bind mount will continue to be accessible and writable. This is the same as other Linux file systems. > And when I remount the main mount point back, cleanerd grabs the bind > mount. See below: > > # mount -t nilfs2 /dev/mapper/hi320data /mnt/hi320data > mount.nilfs2: WARNING! - The NILFS on-disk format may change at any > time. > mount.nilfs2: WARNING! - Do not place critical data on a NILFS > filesystem. > # umount /mnt/bind-test > umount: /mnt/bind-test: device is busy > umount: /mnt/bind-test: device is busy > > # fuser -c /mnt/bind-test/ > /mnt/bind-test/: 23203 > > # ps -Af | grep 23203 > root 23203 1 1 19:06 ? 00:00:00 /sbin/nilfs_cleanerd > -n /dev/mapper/hi320data /mnt/hi320data > > ----------------------- > Maybe it misdetects the bind mount as another mount of the same > filesystem (e.g. like when mounting a snapshot)? Thanks! I could finally reproduce the problem. Nilfs snapshots are readonly, but bind mounts could make multiple r/w-mounts. And, cleanerd prevents umount in such cases. I have to take bind mounts into account, as was expected, in the mount/umount helper programs. I'd like to fix this by the next release. Regards, Ryusuke Konishi