From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sunset.davemloft.net (unknown [74.93.104.97]) by ozlabs.org (Postfix) with ESMTP id 37E3DDDD1C for ; Tue, 24 Mar 2009 05:49:41 +1100 (EST) Date: Mon, 23 Mar 2009 11:49:28 -0700 (PDT) Message-Id: <20090323.114928.01832203.davem@davemloft.net> To: Joakim.Tjernlund@transmode.se Subject: Re: [PATCH] ucc_geth: Convert to net_device_ops From: David Miller In-Reply-To: References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Cc: netdev@vger.kernel.org, leoli@freescale.com, linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Joakim Tjernlund Date: Mon, 23 Mar 2009 11:17:39 +0100 > Sorry for the WS damaged patch, but my current company mailer cannot > handle inline patches. Due to this we are setting up a new mail system > but it will be a few days before this is ready. > Therefore I am attaching this patch as well, use that one > to apply instaed of the inline variant. This patch has other problems, anyways. > +#if 0 > +/* not yet */ > + .ndo_set_mac_address = ucc_geth_set_mac_address, > + .ndo_change_mtu = ucc_geth_change_mtu, > + .ndo_do_ioctl = ucc_geth_do_ioctl, > +#endif Don't do stuff like this, please. Even the code you are copying from doesn't have the set_mac_address method assignment proceted by #if 0 stuff. Just get rid of all the unused stuff completely. From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] ucc_geth: Convert to net_device_ops Date: Mon, 23 Mar 2009 11:49:28 -0700 (PDT) Message-ID: <20090323.114928.01832203.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: leoli@freescale.com, netdev@vger.kernel.org, linuxppc-dev@ozlabs.org, avorontsov@ru.mvista.com To: Joakim.Tjernlund@transmode.se Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:59020 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751083AbZCWStl (ORCPT ); Mon, 23 Mar 2009 14:49:41 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Joakim Tjernlund Date: Mon, 23 Mar 2009 11:17:39 +0100 > Sorry for the WS damaged patch, but my current company mailer cannot > handle inline patches. Due to this we are setting up a new mail system > but it will be a few days before this is ready. > Therefore I am attaching this patch as well, use that one > to apply instaed of the inline variant. This patch has other problems, anyways. > +#if 0 > +/* not yet */ > + .ndo_set_mac_address = ucc_geth_set_mac_address, > + .ndo_change_mtu = ucc_geth_change_mtu, > + .ndo_do_ioctl = ucc_geth_do_ioctl, > +#endif Don't do stuff like this, please. Even the code you are copying from doesn't have the set_mac_address method assignment proceted by #if 0 stuff. Just get rid of all the unused stuff completely.