Re: [PATCH] Documentation: Reworded example text in git-bisect.txt.

["J. Bruce Fields" <bfields@fieldses.org>]

On Sat, Mar 21, 2009 at 05:28:32AM +0100, Christian Couder wrote:
> Le vendredi 20 mars 2009, David J. Mellor a écrit :
> 
> [...]
> 
> > @@ -94,14 +95,14 @@ the bisection state).
> >  Bisect visualize
> >  ~~~~~~~~~~~~~~~~
> >
> > -During the bisection process, you issue the command:
> > +To see the currently remaining suspects in 'gitk', the following command
> > +is issued during the bisection process:
> 
> I think it's better to avoid the passive tone, for example like this:
> 
> "To see the currently remaining suspects in 'gitk', you issue the following 
> command during the bisection process:"

Agreed, but drop the "you" too.

--b.

> 
> >  ------------
> >  $ git bisect visualize
> >  ------------
> 
> [...]
> 
> > @@ -173,8 +175,8 @@ using the "'<commit1>'..'<commit2>'" notation. For
> > example: $ git bisect skip v2.5..v2.6
> >  ------------
> >
> > -would mean that no commit between `v2.5` excluded and `v2.6` included
> > -can be tested.
> > +The effect of this would be that no commit between `v2.5` excluded and
> > +`v2.6` included could be tested.
> 
> I'd prefer something like:
> 
> "This tells the bisect process that no commit between `v2.5` excluded and 
> `v2.6` included can be tested."
> 
> Otherwise it looks good to me.
> 
> Thanks,
> Christian.
> 
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html