From: Al Viro <viro@ZenIV.linux.org.uk>
To: Eric Paris <eparis@redhat.com>
Cc: linux-kernel@vger.kernel.org, hch@infradead.org,
alan@lxorguk.ukuu.org.uk, sfr@canb.auug.org.au,
john@johnmccutchan.com, rlove@rlove.org,
akpm@linux-foundation.org
Subject: Re: [PATCH 10/13] fsnotify: allow groups to add private data to events
Date: Mon, 23 Mar 2009 11:04:29 +0000 [thread overview]
Message-ID: <20090323110429.GQ28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20090319180547.17449.9496.stgit@paris.rdu.redhat.com>
On Thu, Mar 19, 2009 at 02:05:47PM -0400, Eric Paris wrote:
> -int fsnotify_add_notif_event(struct fsnotify_group *group, struct fsnotify_event *event)
> +int fsnotify_add_notif_event(struct fsnotify_group *group, struct fsnotify_event *event, struct fsnotify_event_private_data *priv)
> {
> struct fsnotify_event_holder *holder;
> struct list_head *list = &group->notification_list;
> @@ -166,6 +183,8 @@ int fsnotify_add_notif_event(struct fsnotify_group *group, struct fsnotify_event
>
> fsnotify_get_event(event);
> list_add_tail(&holder->event_list, list);
> + if (priv)
> + list_add_tail(&priv->event_list, &event->private_data_list);
Won't that leak priv if we bugger off earlier? On OOM or on finding last_event
we are OK with...
next prev parent reply other threads:[~2009-03-23 11:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-19 18:04 [PATCH 01/13] mutex: add atomic_dec_and_mutex_lock Eric Paris
2009-03-19 18:05 ` [PATCH 02/13] fsnotify: unified filesystem notification backend Eric Paris
2009-04-07 23:45 ` Paul E. McKenney
2009-03-19 18:05 ` [PATCH 03/13] fsnotify: add group priorities Eric Paris
2009-03-19 18:05 ` [PATCH 04/13] fsnotify: add in inode fsnotify markings Eric Paris
2009-03-23 9:28 ` Al Viro
2009-03-23 9:53 ` Al Viro
2009-03-19 18:05 ` [PATCH 05/13] fsnotify: parent event notification Eric Paris
2009-03-19 18:05 ` [PATCH 06/13] dnotify: reimplement dnotify using fsnotify Eric Paris
2009-03-19 18:05 ` [PATCH 07/13] fsnotify: generic notification queue and waitq Eric Paris
2009-03-19 18:05 ` [PATCH 08/13] fsnotify: include pathnames with entries when possible Eric Paris
2009-03-19 18:05 ` [PATCH 09/13] fsnotify: add correlations between events Eric Paris
2009-03-19 18:05 ` [PATCH 10/13] fsnotify: allow groups to add private data to events Eric Paris
2009-03-23 11:04 ` Al Viro [this message]
2009-03-19 18:05 ` [PATCH 11/13] fsnotify: fsnotify marks on inodes pin them in core Eric Paris
2009-03-19 18:05 ` [PATCH 12/13] fsnotify: handle filesystem unmounts with fsnotify marks Eric Paris
2009-03-19 18:06 ` [PATCH 13/13] inotify: reimplement inotify using fsnotify Eric Paris
2009-03-23 10:29 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090323110429.GQ28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=eparis@redhat.com \
--cc=hch@infradead.org \
--cc=john@johnmccutchan.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rlove@rlove.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.