All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] cpumask: use mm_cpumask() wrapper: powerpc
Date: Mon, 23 Mar 2009 16:13:22 +1030	[thread overview]
Message-ID: <200903231613.23213.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1237530977.25062.572.camel@pasglop>

On Friday 20 March 2009 17:06:17 Benjamin Herrenschmidt wrote:
> On Mon, 2009-03-16 at 14:46 +1030, Rusty Russell wrote:
> > Makes code futureproof against the impending change to mm->cpu_vm_mask.
> >=20
> > It's also a chance to use the new cpumask_ ops which take a pointer
> > (the older ones are deprecated, but there's no hurry for arch code).
>=20
> Boom :-)
>=20
> In file included from /home/benh/linux-powerpc-test/arch/powerpc/kernel/v=
dso.c:30:
> /home/benh/linux-powerpc-test/arch/powerpc/include/asm/mmu_context.h: In =
function =E2=80=98switch_mm=E2=80=99:
> /home/benh/linux-powerpc-test/arch/powerpc/include/asm/mmu_context.h:34: =
error: implicit declaration of function =E2=80=98mm_cpumask=E2=80=99
> /home/benh/linux-powerpc-test/arch/powerpc/include/asm/mmu_context.h:34: =
warning: passing argument 2 of =E2=80=98cpumask_set_cpu=E2=80=99 makes poin=
ter from integer without a cast

Hmm, I think you need to pull from Linus?  He only added the accessor
in "45e575ab (Rusty Russell       2009-03-12 14:35:44 -0600 281)"; you
can't get struct mm_struct without seeing mm_cpumask.

Thanks,
Rusty.

      reply	other threads:[~2009-03-23  5:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-16  4:16 [PATCH] cpumask: use mm_cpumask() wrapper: powerpc Rusty Russell
2009-03-20  6:36 ` Benjamin Herrenschmidt
2009-03-23  5:43   ` Rusty Russell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200903231613.23213.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=benh@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.