Re: [PATCH 3/3] base.bbclass: fix base_get_scmbasepath() to look for recipes/ and fall back to packages/ while parsing BBFILES

[Denys Dmytriyenko <denis@denix.org>]

On Mon, Mar 23, 2009 at 05:57:27AM -0300, Otavio Salvador wrote:
> Denys Dmytriyenko <denis@denix.org> writes:
> 
> 
> [...]
> 
> > --- a/classes/base.bbclass
> > +++ b/classes/base.bbclass
> > @@ -773,7 +773,13 @@ python base_do_unpack() {
> >  def base_get_scmbasepath(d):
> >  	import bb
> >  	path_to_bbfiles = bb.data.getVar( 'BBFILES', d, 1 ).split()
> > -	return path_to_bbfiles[0][:path_to_bbfiles[0].rindex( "packages" )]
> > +
> > +	try:
> > +		index = path_to_bbfiles[0].rindex( "recipes" )
> > +	except ValueError:
> > +		index = path_to_bbfiles[0].rindex( "packages" )
> > +
> > +	return path_to_bbfiles[0][:index]
> >  
> >  def base_get_metadata_monotone_branch(d):
> >  	monotone_branch = "<unknown>"
> 
> In my opinion, while it makes life easier the result of it is mixed
> environments.
> 
> I'm still using packages/ in our local distro and I haven't yet found
> the time to merge current tree since we've a lot of local recipes that
> will break and this change could make it simple but I still refrain
> about having it included.
> 
> It looks like the logical thing is kind of "force" people to handle it.

First you said you are not ready to make the switch, and then you are saying 
we need to force people into it... :)

Anyway, it doesn't matter anymore, as this code has been replaced completely 
by one of kergoth's recent commits.

-- 
Denys