From: Tony Lindgren <tony@atomide.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, rmk@arm.linux.org.uk
Subject: Re: [PATCH 1/2] arm: twl4030 - leak fix
Date: Mon, 23 Mar 2009 09:56:11 -0700 [thread overview]
Message-ID: <20090323165611.GE29546@atomide.com> (raw)
In-Reply-To: <20090323104347.32524.76448.stgit@localhost.localdomain>
* Alan Cox <alan@lxorguk.ukuu.org.uk> [090323 03:45]:
> Trivial error path leak fix. Problem found by Daniel Marjamäki using
> cppcheck
>
> Signed-off-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
Acked-by: Tony Lindgren <tony@atomide.com>
> ---
>
> arch/arm/mach-omap2/mmc-twl4030.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>
> diff --git a/arch/arm/mach-omap2/mmc-twl4030.c b/arch/arm/mach-omap2/mmc-twl4030.c
> index 437f520..e1dadf7 100644
> --- a/arch/arm/mach-omap2/mmc-twl4030.c
> +++ b/arch/arm/mach-omap2/mmc-twl4030.c
> @@ -397,6 +397,7 @@ void __init twl4030_mmc_init(struct twl4030_hsmmc_info *controllers)
> break;
> default:
> pr_err("MMC%d configuration not supported!\n", c->mmc);
> + kfree(mmc);
> continue;
> }
> hsmmc_data[c->mmc - 1] = mmc;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2009-03-23 16:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-23 10:43 [PATCH 0/2] Series short description Alan Cox
2009-03-23 10:43 ` [PATCH 1/2] arm: twl4030 - leak fix Alan Cox
2009-03-23 16:56 ` Tony Lindgren [this message]
2009-03-23 10:44 ` [PATCH 2/2] arm: fix leak in iop13xx/pci Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090323165611.GE29546@atomide.com \
--to=tony@atomide.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.