From: Marek Vasut <marek.vasut@gmail.com>
To: Holger Schurig <hs4233@mail.mn-solutions.de>
Cc: linux-wireless@vger.kernel.org, libertas-dev@lists.infradead.org
Subject: Re: [PATCH] Marvell CF8381 and CF8305
Date: Mon, 23 Mar 2009 16:59:05 +0100 [thread overview]
Message-ID: <200903231659.05158.marek.vasut@gmail.com> (raw)
In-Reply-To: <200903231313.10699.hs4233@mail.mn-solutions.de>
[-- Attachment #1: Type: text/plain, Size: 97 bytes --]
Here's the other patch.
I also added cf8305 support (if_cs.c patched this way works for it too).
[-- Attachment #2: 0002-Add-support-for-CF8381-and-CF8305-WiFi-card.patch --]
[-- Type: text/x-diff, Size: 3291 bytes --]
From 4c7fcf79de8ba900c4a9a56e68c9da89491dff27 Mon Sep 17 00:00:00 2001
From: Marek Vasut <marek.vasut@gmail.com>
Date: Mon, 23 Mar 2009 16:50:30 +0100
Subject: [PATCH 2/2] Add support for CF8381 and CF8305 WiFi card.
Two detection functions were added for identifying CF8381 and CF8305.
Also, CF8305 uses only one-stage firmware, so handle this as well.
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
---
drivers/net/wireless/libertas/if_cs.c | 35 ++++++++++++++++++++++++++++++--
1 files changed, 32 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/libertas/if_cs.c b/drivers/net/wireless/libertas/if_cs.c
index 3f02e6a..e115c8f 100644
--- a/drivers/net/wireless/libertas/if_cs.c
+++ b/drivers/net/wireless/libertas/if_cs.c
@@ -273,7 +273,28 @@ static int if_cs_poll_while_fw_download(struct if_cs_card *card, uint addr, u8 r
*/
#define IF_CS_PRODUCT_ID 0x0000001C
#define IF_CS_CF8385_B1_REV 0x12
+#define IF_CS_CF8381_B3_REV 0x04
+/*
+ * Used to detect other cards than CF8385 since their revisions of silicon
+ * doesn't match those from CF8385, eg. CF8381 B3 works with this driver.
+ */
+#define CF8305_MANFID 0x02db
+#define CF8305_CARDID 0x8103
+#define CF8381_MANFID 0x02db
+#define CF8381_CARDID 0x6064
+
+static inline int if_cs_hw_is_cf8305(struct pcmcia_device *p_dev)
+{
+ return (p_dev->manf_id == CF8305_MANFID &&
+ p_dev->card_id == CF8305_CARDID);
+}
+
+static inline int if_cs_hw_is_cf8381(struct pcmcia_device *p_dev)
+{
+ return (p_dev->manf_id == CF8381_MANFID &&
+ p_dev->card_id == CF8381_CARDID);
+}
/********************************************************************/
/* I/O and interrupt handling */
@@ -757,6 +778,7 @@ static void if_cs_release(struct pcmcia_device *p_dev)
static int if_cs_probe(struct pcmcia_device *p_dev)
{
int ret = -ENOMEM;
+ unsigned int prod_id;
struct lbs_private *priv;
struct if_cs_card *card;
/* CIS parsing */
@@ -859,15 +881,20 @@ static int if_cs_probe(struct pcmcia_device *p_dev)
p_dev->io.BasePort1 + p_dev->io.NumPorts1 - 1);
/* Check if we have a current silicon */
- if (if_cs_read8(card, IF_CS_PRODUCT_ID) < IF_CS_CF8385_B1_REV) {
- lbs_pr_err("old chips like 8385 rev B1 aren't supported\n");
+ prod_id = if_cs_read8(card, IF_CS_PRODUCT_ID);
+ if (!(if_cs_hw_is_cf8305(p_dev) ||
+ (if_cs_hw_is_cf8381(p_dev) &&
+ prod_id >= IF_CS_CF8381_B3_REV)) &&
+ (prod_id < IF_CS_CF8385_B1_REV)) {
+ lbs_pr_err("old chips like 8385 rev B1 or "
+ "8381 rev B3 aren't supported\n");
ret = -ENODEV;
goto out2;
}
/* Load the firmware early, before calling into libertas.ko */
ret = if_cs_prog_helper(card);
- if (ret >= 0)
+ if (ret >= 0 && !if_cs_hw_is_cf8305(p_dev))
ret = if_cs_prog_real(card);
if (ret < 0)
goto out2;
@@ -950,6 +977,8 @@ static void if_cs_detach(struct pcmcia_device *p_dev)
/********************************************************************/
static struct pcmcia_device_id if_cs_ids[] = {
+ PCMCIA_DEVICE_MANF_CARD(CF8305_MANFID, CF8305_CARDID),
+ PCMCIA_DEVICE_MANF_CARD(CF8381_MANFID, CF8381_CARDID),
PCMCIA_DEVICE_MANF_CARD(0x02df, 0x8103),
PCMCIA_DEVICE_NULL,
};
--
1.6.2
next prev parent reply other threads:[~2009-03-23 15:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-22 0:27 [PATCH] Marvell CF8381 Marek Vasut
2009-03-22 4:11 ` Marek Vasut
2009-03-22 8:04 ` Johannes Berg
2009-03-22 13:01 ` Marek Vasut
2009-03-22 13:03 ` Johannes Berg
2009-03-23 12:27 ` Holger Schurig
2009-03-23 16:15 ` Dan Williams
2009-03-23 21:58 ` Marek Vasut
2009-03-23 23:08 ` Dan Williams
2009-03-23 23:42 ` Marek Vasut
2009-03-24 10:26 ` Dan Williams
2009-03-24 20:01 ` John W. Linville
2009-03-24 20:33 ` Marek Vasut
2009-03-23 12:13 ` Holger Schurig
2009-03-23 14:34 ` Marek Vasut
2009-03-23 15:57 ` [PATCH1/2] Fix return value handling Marek Vasut
2009-03-23 15:59 ` Marek Vasut
2009-03-23 16:11 ` Dan Williams
2009-03-23 15:59 ` Marek Vasut [this message]
2009-03-23 16:00 ` [PATCH] Marvell CF8381 and CF8305 Marek Vasut
2009-03-23 16:06 ` Holger Schurig
2009-03-23 17:09 ` Marek Vasut
2009-03-23 17:19 ` Dan Williams
2009-03-23 17:39 ` Marek Vasut
2009-03-23 16:58 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903231659.05158.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=hs4233@mail.mn-solutions.de \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.