From: "Bob Copeland" <me@bobcopeland.com>
To: Johannes Berg <johannes@sipsolutions.net>,
Kalle Valo <kalle.valo@iki.fi>
Cc: "Alexander E. Patrakov" <patrakov@gmail.com>,
linux-wireless@vger.kernel.org, mb@bu3sch.de
Subject: Re: Kernel panic with zd1211rw and today's compat-wireless
Date: Mon, 23 Mar 2009 14:52:07 -0500 [thread overview]
Message-ID: <20090323194523.M76544@bobcopeland.com> (raw)
In-Reply-To: <1237836988.6147.18.camel@johannes.local>
On Mon, 23 Mar 2009 20:36:28 +0100, Johannes Berg wrote
> I think I'm in favour of "downgrading" that to a WARN_ON, like this:
> if (WARN_ON(...))
> info->control.rates[0].idx = rate_lowest()
>
> johannes
How about the similar WARN_ON() in ieee80211_get_tx_rate()? Does
it make sense to try and tx a frame but return null for the rate
structure?
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2009-03-23 19:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-22 12:45 Kernel panic with zd1211rw and today's compat-wireless Alexander E. Patrakov
2009-03-22 12:56 ` Johannes Berg
2009-03-22 13:15 ` Michael Buesch
2009-03-22 14:49 ` Bob Copeland
2009-03-22 15:09 ` Michael Buesch
2009-03-22 22:04 ` Bob Copeland
2009-03-22 22:12 ` Michael Buesch
2009-03-23 15:08 ` Kalle Valo
2009-03-23 19:36 ` Johannes Berg
2009-03-23 19:52 ` Bob Copeland [this message]
2009-03-23 19:56 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090323194523.M76544@bobcopeland.com \
--to=me@bobcopeland.com \
--cc=johannes@sipsolutions.net \
--cc=kalle.valo@iki.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=patrakov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.