Re: Patch implementing V4L2_CAP_STREAMING for zr364xx driver

[Lamarque Vieira Souza <lamarque@gmail.com>]

Em Monday 23 March 2009, Alexey Klimov escreveu:
> Hello, Lamarque
>
> On Tue, Mar 24, 2009 at 2:11 AM, Lamarque Vieira Souza
> <lamarque@gmail.com>wrote:
>
> <snip>
>
> > > +static void read_pipe_completion(struct urb *purb)
> > > +{
> > > +     struct zr364xx_pipeinfo *pipe_info;
> > > +     struct zr364xx_camera *cam;
> > > +     int status;
> > > +     int pipe;
> > > +
> > > +     pipe_info = purb->context;
> > > +     DBG("%s %p, status %d\n", __func__, purb, purb->status);
> > > +     if (pipe_info == NULL) {
> > > +             err("no context!");
> > >
> > >
> > > +             return;
> > > +     }
> > > +
> > > +     cam = pipe_info->cam;
> > > +     if (cam == NULL) {
> > > +             err("no context!");
> > >
> > > Do you use err() macro from usb.h ?
> > > If yes - as i know it's better not to use this macros, because this
> >
> > macros
> >
> > > can suddenly became deprecated. It's more comfortable to use printk or
> > > dev_err.
> >
> >         Well, s2255drc.c uses it, since my changes are based on that I
> > supposed it
> > could be used. I will change them to printk's.
>
> I saw situation when there were troubles because driver used info() and
> warn() macroses and usb.h wasn't contain these macroses and next-kernel
> tree was some kind of broken. It's definitely  uncomfortable.
>
> > Also, our current maillist is linux-media@vger.kernel.org.
> >
> > > It's better to post patches there.
> >
> >         Ok. When I finish to remove some code I will post the new patch
> > there. That
> > also explain why this list is so calm compared to the other kernel lists
> > I have been to. By the way, do you understande something about
> > pixelformats? I
> > need to convert YUV 4:2:0 into YUV 4:2:2 (UYVY) in libv4l to make my
> > webcam work with Skype. Actually the frame is decoded into uncompressed
> > jpeg before
> > it is converted to YUV 4:2:0, so maybe I do not need to YUV 4:2:0 into
> > YUV 4:2:2 (UYVY). I am just not used to the pixel format details.
>
> Sorry, i can't help you with that :(
> It's one more reason to ask linux-media kernel list.

	Ok, thanks anyway. The resources field in struct zr364xx_camera is need to 
avoid a second call the streamon, so I inlined it as you told me. I change the 
number of frame buffers to 1 as it is in the original zr364xx.c, it is working 
this way, so the driver is going to spend less memory. Now I need to re-
implement V4L2_CAP_READWRITE.

-- 
Lamarque V. Souza
http://www.geographicguide.com/brazil.htm
Linux User #57137 - http://counter.li.org/

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list