From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: TOMARI Hisanobu <posco.grubb@gmail.com>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>,
linux-ide@vger.kernel.org, benh@kernel.crashing.org
Subject: Re: [PATCH] IDE cable detection on Apple PowerBook
Date: Mon, 23 Mar 2009 21:09:24 +0100 [thread overview]
Message-ID: <200903232109.24971.bzolnier@gmail.com> (raw)
In-Reply-To: <20090323201121.ab925b5a.posco.grubb@gmail.com>
On Monday 23 March 2009, TOMARI Hisanobu wrote:
> On Mon, 23 Mar 2009 13:57:03 +0300
> Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote:
>
> > Unacceptable style, brace should be on the same line with *if*; run your
> > patch thru scripts/checkpatch.pl please...
> Thank you for telling me the error. Now, this one should be all right.
>
> ---
>
> Signed-off-by: TOMARI Hisanobu <posco.grubb@gmail.com>
> This patch against 2.6.28.8 modifies the behavior of 80c cable detection
> of drivers/ide/pmac.c.
> As IDE cable used on Apple PowerBook/iBook laptops are always of "Short 40"
> type when the firmware says it's 80 conductor one, the cable detection should
> return ATA_CBL_PATA40_SHORT on those machines.
> This enables to automatically use UDMA5 even with drives that doesn't correctly
> detect those cables on Apple laptops.
applied
PS please keep the following ordering in future:
- patch description
- S-o-B line
- "---" line
to allow easier/automatic merging of patches
next prev parent reply other threads:[~2009-03-23 20:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-22 1:17 [PATCH] IDE cable detection on Apple PowerBook TOMARI Hisanobu
2009-03-23 10:57 ` Sergei Shtylyov
2009-03-23 11:11 ` TOMARI Hisanobu
2009-03-23 20:09 ` Bartlomiej Zolnierkiewicz [this message]
2009-03-23 23:44 ` TOMARI Hisanobu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903232109.24971.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=linux-ide@vger.kernel.org \
--cc=posco.grubb@gmail.com \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.