All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC/PATCH 2/8] docbook: improve css style
Date: Tue, 24 Mar 2009 04:42:36 -0400	[thread overview]
Message-ID: <20090324084236.GC660@coredump.intra.peff.net> (raw)
In-Reply-To: <94a0d4530903231720r620e44fu90dd77a3231bd4d1@mail.gmail.com>

On Tue, Mar 24, 2009 at 02:20:13AM +0200, Felipe Contreras wrote:

> I've updated the CSS. Can you take a look again?
> 
> I changed the font-size to normal, except for the code chunks. Also, I

Well, it looks better to me, in that the body text isn't small and
scrunched. The code chunks are, of course, noticeably smaller. I really
don't see what you're trying to accomplish with that. Are you trying to
make it fit into browsers where we are somehow wrapping in the code
chunks?

> changed the font of the in-paragrah code tags to sans-serif, that's
> the most sane way I can think to fix the problem with different
> font-size configured for monospace font.

Hrm. I'm not sure that is particularly sane. You have the style for a
<tt> tag rendering as a sans-serif font. But the _definition_ of tt is
to render as a monospace font.

As it happens, there are no <tt> tags at all in the document, so that
change is irrelevant (and I wonder if we should ditch the tt.literal
specifier entirely). But I tend to think that <code> tags generally
follow the same principle. Looking over the document, I didn't find
anything that looked broken by it (at least in Firefox using my set of
fonts). But it just seems counterintuitive.

If you are unsatisfied with the size of the text in <code> blocks,
can't you set some variant of an em (e.g., 1.1em)?


Looking at all of these <code> examples did make me notice one thing:
there are some special characters used that are probably
counterintuitive. For instance, "--not" is rendered with a single long
dash instead of two short dashes. A code snippet has a right-arrow
character instead of "->". I assume this is asciidoc trying to be
clever, but I haven't looked into it.

-Peff

  reply	other threads:[~2009-03-24  8:44 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-22 18:05 [RFC/PATCH 0/8] user-manual: style improvements Felipe Contreras
2009-03-22 18:05 ` [RFC/PATCH 1/8] user-manual: remove some git-foo usage Felipe Contreras
2009-03-22 18:05   ` [RFC/PATCH 2/8] docbook: improve css style Felipe Contreras
2009-03-22 18:05     ` [RFC/PATCH 3/8] docbook: radical style change Felipe Contreras
     [not found]       ` <1237745121-6325-5-git-send-email-felipe.contreras@gmail.com>
2009-03-22 18:05         ` [RFC/PATCH 5/8] user-manual: use 'fast-forward' instead of 'fast forward' Felipe Contreras
2009-03-22 18:05           ` [RFC/PATCH 6/8] user-manual: use SHA-1 instead of SHA1 or sha1 Felipe Contreras
2009-03-22 18:05             ` [RFC/PATCH 7/8] user-manual: add global config section Felipe Contreras
2009-03-22 18:05               ` [RFC/PATCH 8/8] user-manual: simplify the user configuration Felipe Contreras
2009-03-22 22:42                 ` Wincent Colaiuta
2009-03-22 23:01                   ` Felipe Contreras
2009-03-23  0:00                     ` Junio C Hamano
2009-03-23 11:02                       ` Felipe Contreras
2009-03-23  0:07                     ` Wincent Colaiuta
2009-03-23 11:07                       ` Felipe Contreras
2009-03-23 11:09                         ` Wincent Colaiuta
2009-03-24  0:22                           ` Felipe Contreras
2009-03-24 21:52               ` [RFC/PATCH 7/8] user-manual: add global config section J. Bruce Fields
2009-03-24 22:17                 ` Felipe Contreras
2009-03-24 22:42                   ` J. Bruce Fields
2009-03-23  6:50       ` [RFC/PATCH 3/8] docbook: radical style change Jeff King
2009-03-23 10:47         ` Felipe Contreras
2009-03-23  6:42     ` [RFC/PATCH 2/8] docbook: improve css style Jeff King
2009-03-23 10:31       ` Felipe Contreras
2009-03-23 15:20         ` Michael J Gruber
2009-03-24  0:21           ` Felipe Contreras
2009-03-24  2:08             ` Junio C Hamano
2009-03-24  7:52               ` Felipe Contreras
2009-03-24  8:18                 ` Jeff King
2009-03-24  8:57                   ` Felipe Contreras
2009-03-24  9:00                     ` Jeff King
2009-03-24  9:39                       ` Felipe Contreras
2009-03-24  8:29             ` Michael J Gruber
2009-03-24  9:06               ` Felipe Contreras
2009-03-24  9:16                 ` Jeff King
2009-03-24 10:39                 ` Michael J Gruber
2009-03-24 10:52                   ` Felipe Contreras
2009-03-24  0:20       ` Felipe Contreras
2009-03-24  8:42         ` Jeff King [this message]
2009-03-23  6:31   ` [RFC/PATCH 1/8] user-manual: remove some git-foo usage Jeff King
2009-03-23 10:54     ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090324084236.GC660@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.