All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: eduard.munteanu@linux360.ro, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kmemtrace: fix build breakage in befs
Date: Tue, 24 Mar 2009 09:56:58 +0100	[thread overview]
Message-ID: <20090324085658.GG13016@elte.hu> (raw)
In-Reply-To: <1237884846.25315.37.camel@penberg-laptop>


* Pekka Enberg <penberg@cs.helsinki.fi> wrote:

> On Tue, 2009-03-24 at 09:51 +0100, Ingo Molnar wrote:
> > there's another build problem as well, in squashfs, and in key.h:
> > 
> >  include/linux/key.h:128: error: field 'sem' has incomplete type
> >  fs/squashfs/export.c:133: error: implicit declaration of function 'kmalloc'
> >  fs/squashfs/export.c:143: error: implicit declaration of function 'kfree'
> > 
> > And i suspect there's more as well. Is there really no unintrusive 
> > way to solve this - or do you think the RCU change reduces the 
> > include file spaghetti?
> 
> I don't think there is and yes, I do think the RCU change cleans 
> up things as well.

Okay. Note, you'll have to test tip:tracing/kmemtrace explicitly as 
i had to exclude it from tip:master due to test failures. Will put 
it back in once fixes arrive :)

	Ingo

  reply	other threads:[~2009-03-24  8:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-24  8:43 [PATCH] kmemtrace: fix build breakage in befs Pekka Enberg
2009-03-24  8:51 ` Ingo Molnar
2009-03-24  8:54   ` Pekka Enberg
2009-03-24  8:56     ` Ingo Molnar [this message]
2009-03-24  8:57       ` Pekka Enberg
2009-03-24  9:07         ` Ingo Molnar
2009-03-24  9:15           ` Pekka Enberg
2009-03-24  9:17             ` Ingo Molnar
2009-03-24  9:22               ` Pekka Enberg
2009-03-24  9:31                 ` Ingo Molnar
2009-03-24  9:34                   ` Ingo Molnar
2009-03-24  9:46                     ` Ingo Molnar
2009-03-24 10:12                       ` Ingo Molnar
2009-03-24 10:34                         ` Ingo Molnar
2009-03-24  9:38                   ` Pekka Enberg
2009-03-24  9:53                     ` Ingo Molnar
2009-03-24 13:09                       ` Alexey Dobriyan
2009-03-24 13:11                         ` Pekka Enberg
2009-03-24 16:32             ` Eduard - Gabriel Munteanu
2009-03-24 21:02               ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090324085658.GG13016@elte.hu \
    --to=mingo@elte.hu \
    --cc=eduard.munteanu@linux360.ro \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.