From: Greg KH <greg@kroah.com>
To: stoyboyker@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 07/13] [usb] changed ioctls to unlocked
Date: Tue, 24 Mar 2009 15:09:53 -0700 [thread overview]
Message-ID: <20090324220953.GA5835@kroah.com> (raw)
In-Reply-To: <1237929168-15341-8-git-send-email-stoyboyker@gmail.com>
On Tue, Mar 24, 2009 at 04:12:42PM -0500, stoyboyker@gmail.com wrote:
> From: Stoyan Gaydarov <stoyboyker@gmail.com>
>
> Signed-off-by: Stoyan Gaydarov <stoyboyker@gmail.com>
> ---
> drivers/usb/mon/mon_bin.c | 53 ++++++++++++++++++++++++++++++++------------
> 1 files changed, 38 insertions(+), 15 deletions(-)
NAK, you're just pushing lock_kernel() down for no good reason.
the code should be fixed to not need the lock at all.
thanks,
greg k-h
next prev parent reply other threads:[~2009-03-24 22:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-24 21:12 [PATCH 07/13] [usb] changed ioctls to unlocked stoyboyker
2009-03-24 22:09 ` Greg KH [this message]
2009-03-24 22:20 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090324220953.GA5835@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stoyboyker@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.