Re: [Qemu-devel] [BUG] [PATCH] [STABLE] Fix monitor command (screendump)

[Ryan Harper <ryanh@us.ibm.com>]

* Stefan Weil <weil@mail.berlios.de> [2009-03-24 17:16]:
> Hello,
> 
> starting with r6839, the monitor command 'screendump'
> raises a nullpointer memory access which crashs Qemu.
> 
> My patch fixes this for trunk and for the stable branch.
> 
> Regards
> 
> Stefan
> 
> PS. There are a lot of unapplied patches (not only from me)
> which really should be applied to trunk. Much time and efforts
> are wasted for maintaining local patch trees, some fixes
> are sent 3 times by different people. How can we improve
> this insatisfying situation?
> 
> 
> 
> 
> 

> Fix crash when calling screendump from monitor.
> 
> This was a regression introduced with r6839:
> DisplayAllocator interface (Stefano Stabellini)
> 
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>

Acked-by: Ryan Harper <ryanh@us.ibm.com>

> 
> Index: trunk/hw/vga.c
> ===================================================================
> --- trunk.orig/hw/vga.c	2009-03-24 19:35:00.000000000 +0100
> +++ trunk/hw/vga.c	2009-03-24 19:37:56.000000000 +0100
> @@ -2637,6 +2637,7 @@
>      dcl.dpy_resize = vga_save_dpy_resize;
>      dcl.dpy_refresh = vga_save_dpy_refresh;
>      register_displaychangelistener(ds, &dcl);
> +    ds->allocator = &default_allocator;
>      ds->surface = qemu_create_displaysurface(ds, w, h);
> 
>      s->ds = ds;


-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ryanh@us.ibm.com