From: Matthew Wilcox <matthew@wil.cx>
To: stoyboyker@gmail.com
Cc: linux-kernel@vger.kernel.org,
James.Bottomley@HansenPartnership.com,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 06/13] [scsi] changed ioctls to unlocked
Date: Tue, 24 Mar 2009 22:21:09 -0600 [thread overview]
Message-ID: <20090325042109.GP14127@parisc-linux.org> (raw)
In-Reply-To: <1237929168-15341-7-git-send-email-stoyboyker@gmail.com>
On Tue, Mar 24, 2009 at 04:12:41PM -0500, stoyboyker@gmail.com wrote:
> +static long osst_ioctl(struct file * file, unsigned int cmd_in,
> + unsigned long arg)
> {
> + lock_kernel();
> int i, cmd_nr, cmd_type, blk, retval = 0;
Did you try compiling this? If so, what compiler did you use? You
*should* have got an error about mixing code and declarations.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
prev parent reply other threads:[~2009-03-25 4:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-24 21:12 [PATCH 06/13] [scsi] changed ioctls to unlocked stoyboyker
2009-03-24 21:24 ` James Bottomley
2009-03-24 21:28 ` Stoyan Gaydarov
2009-03-24 21:28 ` Stoyan Gaydarov
2009-03-25 4:21 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090325042109.GP14127@parisc-linux.org \
--to=matthew@wil.cx \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stoyboyker@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.