From: Nikanth Karthikesan <knikanth@suse.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Steven Rostedt <srostedt@redhat.com>,
rusty@rustcorp.com.au, Ingo Molnar <mingo@elte.hu>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: ftrace not working?
Date: Wed, 25 Mar 2009 09:36:05 +0530 [thread overview]
Message-ID: <200903250936.06349.knikanth@suse.de> (raw)
In-Reply-To: <alpine.DEB.2.00.0903242220140.22830@gandalf.stny.rr.com>
On Wednesday 25 March 2009 07:51:34 Steven Rostedt wrote:
> On Tue, 24 Mar 2009, Frederic Weisbecker wrote:
> > > Steve, Can you merge this.
> > >
> > > Thanks
> > > Nikanth
> > >
> > > In tracer_alloc_buffers(), do not free tracing_cpumask and
> > > tracing_buffer_mask on success.
> > >
> > > Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>
> > >
> > > ---
> > >
> > > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> > > index 17bb88d..98f609d 100644
> > > --- a/kernel/trace/trace.c
> > > +++ b/kernel/trace/trace.c
> > > @@ -3887,6 +3887,7 @@ __init static int tracer_alloc_buffers(void)
> > >
> > > register_die_notifier(&trace_die_notifier);
> > > ret = 0;
> > > + goto out;
> >
> > Ah I see.
> > I've sent a fix for that already, it's on latest -tip
> > http://git.kernel.org/?p=linux/kernel/git/tip/linux-2.6-tip.git;a=commit;
> >h=2fc1dfbe17e7705c55b7a99da995fa565e26f151
>
> Nikanth,
>
> Could you varify that tip is not an issue for you.
>
> http://people.redhat.com/~mingo/tip.git/readme.txt
>
Oh. That should fix it. It would be nice to have it in stable 2.6.29.1.
Thanks
Nikanth
next prev parent reply other threads:[~2009-03-25 4:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-23 6:38 ftrace not working? Nikanth Karthikesan
2009-03-23 7:15 ` Frederic Weisbecker
2009-03-23 8:41 ` Frederic Weisbecker
2009-03-23 8:44 ` Nikanth Karthikesan
2009-03-23 11:25 ` Frederic Weisbecker
2009-03-23 11:33 ` Nikanth Karthikesan
2009-03-23 8:08 ` KOSAKI Motohiro
2009-03-23 8:27 ` Nikanth Karthikesan
2009-03-23 8:35 ` Ingo Molnar
2009-03-23 8:38 ` Nikanth Karthikesan
2009-03-23 11:01 ` KOSAKI Motohiro
2009-03-23 14:32 ` Ingo Molnar
2009-03-24 17:23 ` Nikanth Karthikesan
2009-03-24 20:13 ` Frederic Weisbecker
2009-03-25 2:21 ` Steven Rostedt
2009-03-25 4:06 ` Nikanth Karthikesan [this message]
2009-03-25 4:19 ` Steven Rostedt
2009-03-25 1:08 ` Rusty Russell
2009-03-25 3:21 ` KOSAKI Motohiro
2009-03-25 7:27 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903250936.06349.knikanth@suse.de \
--to=knikanth@suse.de \
--cc=fweisbec@gmail.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=srostedt@redhat.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.