Re: [PATCH] powerpc/wdrtas: Update wdrtas_get_interval to use rtas_data_buf

[Mark Nelson <markn@au1.ibm.com>]

On Wed, 25 Mar 2009 01:31:32 am Utz Bacher wrote:
> Adrian Reber <adrian@lisas.de> wrote on 24.03.2009 13:31:31:
> > On Tue, Mar 24, 2009 at 05:30:41PM +1100, Mark Nelson wrote:
> > > The buffer passed to the ibm,get-system-parameter RTAS call must be
> > > in the RMA. To ensure we pass an address in the RMA use rtas_data_buf
> > > for the actual RTAS call and then copy the result to value. We can't
> > > just make it static because this can be compiled in as a module.
> > > 
> > > Also add the WDRTAS_SP_SPI_LEN so we don't litter '4' throughout the
> > > function.
> > > 
> > > Signed-off-by: Mark Nelson <markn@au1.ibm.com>
> > > ---
> > > 
> > > Adrian, does this patch cause any problems for your pxcabs?
> > 
> > No, it even helps. I have no tried the watchdog until now, but without 
> the
> > patch I get: 
> > 
> >    wdrtas: could not get sp_spi watchdog timeout (0). Continuing
> > 
> > and with the patch it reads the correct value. So only with your patch
> > it works like it is supposed to. Thanks!
> > 
> > Tested-by: Adrian Reber <adrian@lisas.de>
> 
> looks good to me.
> 
> Acked-by: Utz Bacher <utz.bacher@de.ibm.com>

Thanks for looking over it!
Mark