All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 4/4] Flex-OneNAND boundary setting command
Date: Wed, 25 Mar 2009 12:23:19 -0500	[thread overview]
Message-ID: <20090325172319.GA23631@loki.buserror.net> (raw)
In-Reply-To: <30550E23C11643FF9064DFEDC982029E@sisodomain.com>

On Wed, Mar 25, 2009 at 08:44:37PM +0530, Amul Kumar Saha wrote:
> >> +    die = (int) simple_strtoul(argv[2], NULL, 0);
> >> +    bdry = (int) simple_strtoul(argv[3], NULL, 0);
> > 
> > Casts should not be necessary.
> > 
> 
> I believe that typecasting a UL to an int, is OK.
> Do let me know.

The compiler will implicitly cast unsigned long to int.  The explicit cast
is unnecessary clutter which makes it harder to find casts that aren't OK.

-Scott

  reply	other threads:[~2009-03-25 17:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-11 14:27 [U-Boot] [PATCH v2 4/4] Flex-OneNAND boundary setting command Rohit Hagargundgi
2009-03-08  6:47 ` Rohit Hagargundgi
2009-03-09 21:38   ` Scott Wood
2009-03-23  7:06     ` Amul Kumar Saha
2009-03-23 20:17       ` Scott Wood
2009-03-25 15:14     ` Amul Kumar Saha
2009-03-25 17:23       ` Scott Wood [this message]
2009-03-26 12:21         ` Amul Kumar Saha
2009-03-26 12:35         ` Amul Kumar Saha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090325172319.GA23631@loki.buserror.net \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.