From: Jens Axboe <jens.axboe@oracle.com>
To: Nikanth Karthikesan <knikanth@suse.de>
Cc: zdenek.kabelac@gmail.com, bunk@kernel.org, jirislaby@gmail.com,
hidave.darkstar@gmail.com, viro@zeniv.linux.org.uk,
linux-kernel@vger.kernel.org, nikanth@gmail.com
Subject: Re: [PATCH] Fix Bug 10504 - losetup possible circular locking
Date: Thu, 26 Mar 2009 10:48:47 +0100 [thread overview]
Message-ID: <20090326094847.GN27476@kernel.dk> (raw)
In-Reply-To: <200903261512.22775.knikanth@suse.de>
On Thu, Mar 26 2009, Nikanth Karthikesan wrote:
> On Tuesday 24 March 2009 17:00:32 Jens Axboe wrote:
> > On Tue, Mar 24 2009, Nikanth Karthikesan wrote:
> > > Hi Jens
> > >
> > > Did you get to look at this? Can you ACK/NACK this one?
> >
> > It looks fine, I have applied it.
> >
>
> Thanks. But it looks like, the patch I quoted in the changelog had the "---"
> delimiter, which made you commit without the full changelog and signed-off.
> Sorry for that mistake.
That was actually done on purpose, I wanted the whole thing there! It
was a lot more useful than the short summary. Never be afraid to write
exhaustive changelogs, I even put the test app in there for some cases
when that makes sense.
--
Jens Axboe
next prev parent reply other threads:[~2009-03-26 9:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-12 8:11 [PATCH] Fix Bug 10504 - losetup possible circular locking Nikanth Karthikesan
2009-03-24 5:52 ` Nikanth Karthikesan
2009-03-24 11:30 ` Jens Axboe
2009-03-26 9:42 ` Nikanth Karthikesan
2009-03-26 9:48 ` Jens Axboe [this message]
2009-03-26 9:52 ` Nikanth Karthikesan
2009-03-26 9:59 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090326094847.GN27476@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=bunk@kernel.org \
--cc=hidave.darkstar@gmail.com \
--cc=jirislaby@gmail.com \
--cc=knikanth@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nikanth@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=zdenek.kabelac@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.