From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Cc: linuxppc-dev@ozlabs.org, leoli@freescale.com, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] ucc_geth: Rework the TX logic.
Date: Thu, 26 Mar 2009 21:05:43 +0300 [thread overview]
Message-ID: <20090326180543.GA2406@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <OF5FC70952.28684E98-ONC1257585.005ADBF9-C1257585.005BDD35@transmode.se>
On Thu, Mar 26, 2009 at 05:43:25PM +0100, Joakim Tjernlund wrote:
[...]
> > bd == ugeth->confBd[txQ]
> > and
> > !in_be32((u32 __iomem *)(bd+4))
> >
> > Are not equivalent wrt. speed. MMIO accessors should be rather
> > slow comparing to normal memory.
>
> Yes, I know. I did it this way because I something broke under stress
> when ugeth->confBd[txQ] instead. The ucc_geth_tx() and
> ucc_geth_start_xmit()
> gets out of sync somehow.
Would be great if you could investigate it more. Maybe there is
a serious bug somewhere, or maybe you're introducing another
(yet hidden) bug...
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2009-03-26 18:05 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-26 12:54 [PATCH 1/2] ucc_geth: Move freeing of TX packets to NAPI context Joakim Tjernlund
2009-03-26 12:54 ` [PATCH 2/2] ucc_geth: Rework the TX logic Joakim Tjernlund
2009-03-26 13:39 ` Anton Vorontsov
2009-03-26 16:43 ` Joakim Tjernlund
2009-03-26 16:43 ` Joakim Tjernlund
2009-03-26 18:05 ` Anton Vorontsov [this message]
2009-03-26 18:20 ` Joakim Tjernlund
2009-03-26 18:20 ` Joakim Tjernlund
2009-03-27 7:42 ` David Miller
2009-03-27 7:42 ` David Miller
2009-03-27 9:37 ` Joakim Tjernlund
2009-03-26 14:15 ` [PATCH 1/2] ucc_geth: Move freeing of TX packets to NAPI context Eric Dumazet
2009-03-26 14:15 ` Eric Dumazet
2009-03-26 16:55 ` Joakim Tjernlund
2009-03-26 16:55 ` Joakim Tjernlund
2009-03-26 18:26 ` [RFC] niu: RX queues should rotate if budget exhausted Eric Dumazet
2009-03-27 7:55 ` David Miller
2009-03-27 7:58 ` David Miller
2009-03-27 8:05 ` Eric Dumazet
2009-03-27 10:50 ` [PATCH 1/2] ucc_geth: Move freeing of TX packets to NAPI context Li Yang
2009-03-27 10:50 ` Li Yang
2009-03-27 11:52 ` Joakim Tjernlund
2009-03-27 21:55 ` David Miller
2009-03-27 21:55 ` David Miller
2009-03-30 7:36 ` Li Yang
2009-03-30 7:36 ` Li Yang
2009-03-30 7:48 ` Joakim Tjernlund
2009-03-30 7:48 ` Joakim Tjernlund
2009-03-30 7:57 ` Li Yang
2009-03-30 7:57 ` Li Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090326180543.GA2406@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=Joakim.Tjernlund@transmode.se \
--cc=leoli@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.