From: Rusty Russell <rusty@rustcorp.com.au>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: lguest@ozlabs.org, Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 3/5] lguest: avoid accidental recycling of pgdir pages
Date: Fri, 27 Mar 2009 11:54:20 +1030 [thread overview]
Message-ID: <200903271154.22450.rusty@rustcorp.com.au> (raw)
In-Reply-To: <49CC1B1C.3080102@goop.org>
On Friday 27 March 2009 10:47:32 Jeremy Fitzhardinge wrote:
> Rusty Russell wrote:
> > Impact: potential bugfix
> >
> > In theory, the kernel could reuse the same page as pgdir for a new process
> > while the hypervisor keeps it cached. This would have undesirable results.
> >
>
> You can't just do this in tlb flush?
I don't think so. The problem is that lguest tracks 4 toplevels, using random
replacement. This cache is indexed by cr3 value.
Lguest assumes it's told about all pte removals or changes, but simple
additions get faulted in. If a pgdir page gets reused we'll potentially have
stale values from its previous life as a pgdir, no?
Now, I haven't *seen* this happen...
Rusty.
next prev parent reply other threads:[~2009-03-27 1:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-26 23:52 [PATCH 3/5] lguest: avoid accidental recycling of pgdir pages Rusty Russell
2009-03-27 0:17 ` Jeremy Fitzhardinge
2009-03-27 1:24 ` Rusty Russell
2009-03-27 1:24 ` Rusty Russell [this message]
2009-03-27 16:28 ` Jeremy Fitzhardinge
2009-03-27 16:28 ` Jeremy Fitzhardinge
2009-03-27 16:33 ` Jeremy Fitzhardinge
2009-03-28 6:37 ` Rusty Russell
2009-03-28 6:37 ` Rusty Russell
2009-03-27 16:33 ` Jeremy Fitzhardinge
-- strict thread matches above, loose matches on Subject: below --
2009-03-26 23:52 Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903271154.22450.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=jeremy@goop.org \
--cc=lguest@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.