From: "Shawn O. Pearce" <spearce@spearce.org>
To: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Cc: Marek Zawirski <marek.zawirski@gmail.com>,
Daniel Cheng <j16sdiz+freenet@gmail.com>,
git@vger.kernel.org
Subject: Re: patch series starting with [JGIT PATCH 1/5] Remove dead/unused reset method from CountingOutputStream
Date: Fri, 27 Mar 2009 07:51:00 -0700 [thread overview]
Message-ID: <20090327145100.GM23521@spearce.org> (raw)
In-Reply-To: <200903270911.54571.robin.rosenberg.lists@dewire.com>
Robin Rosenberg <robin.rosenberg.lists@dewire.com> wrote:
>
> More related, I also noted that the git:// ssh or file: clone calculates the CRC's separately
> and wasn't subject to this bug.
clone (or fetch) is going through IndexPack, which has its own logic
to tear apart a pack file and build up the table of contents of
that pack in the most efficient method possible. Its an entirely
different code base than writing a pack, because its going the
other direction. :-)
The new test case at least validates that both IndexPack and
PackWriter produce the same information in the .idx file.
--
Shawn.
next prev parent reply other threads:[~2009-03-27 14:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-26 1:21 [JGIT PATCH 1/5] Remove dead/unused reset method from CountingOutputStream Shawn O. Pearce
2009-03-26 1:21 ` [JGIT PATCH 2/5] Implement CRC32 computation during PackWriter Shawn O. Pearce
2009-03-26 1:21 ` [JGIT PATCH 3/5] Test case for pack index CRC32 when written by PackWriter Shawn O. Pearce
2009-03-26 1:21 ` [JGIT PATCH 4/5] Write the pack header in one shot Shawn O. Pearce
2009-03-26 1:21 ` [JGIT PATCH 5/5] Use Deflater directly in PackWriter Shawn O. Pearce
2009-03-26 15:35 ` [JGIT PATCH 3/5] Test case for pack index CRC32 when written by PackWriter Daniel Cheng
2009-03-26 15:35 ` Daniel Cheng
2009-03-27 8:11 ` patch series starting with [JGIT PATCH 1/5] Remove dead/unused reset method from CountingOutputStream Robin Rosenberg
2009-03-27 14:51 ` Shawn O. Pearce [this message]
2009-03-27 14:55 ` Shawn O. Pearce
2009-03-27 23:53 ` Robin Rosenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090327145100.GM23521@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=j16sdiz+freenet@gmail.com \
--cc=marek.zawirski@gmail.com \
--cc=robin.rosenberg.lists@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.