From: Matthew Wilcox <matthew@wil.cx>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: James Smart <James.Smart@Emulex.Com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] lpfc : add module parameter that allows adapter instances to avoid attachment
Date: Fri, 27 Mar 2009 09:09:40 -0600 [thread overview]
Message-ID: <20090327150940.GK8014@parisc-linux.org> (raw)
In-Reply-To: <1238100849.3342.58.camel@localhost.localdomain>
On Thu, Mar 26, 2009 at 03:54:09PM -0500, James Bottomley wrote:
> Also (as Randy pointed out) you don't account for the domain. However,
> you could just by not bothering to convert the string to numbers for the
> compare, just compare on dev->bus_id ... which is how a generic one
> would work.
I think it needs to be PCI and not device core. bus_id isn't guaranteed
to be unique between different bus types. I don't know of any that
conflict, but we don't want to inadvertently disable, say, an SBUS
device while trying to disable a PCI device.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2009-03-27 15:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-26 19:55 [PATCH] lpfc : add module parameter that allows adapter instances to avoid attachment James Smart
2009-03-26 20:19 ` James Bottomley
2009-03-26 20:37 ` James Smart
2009-03-26 20:41 ` Randy Dunlap
2009-03-26 20:54 ` James Bottomley
2009-03-27 12:46 ` James Smart
2009-03-27 15:09 ` Matthew Wilcox [this message]
2009-03-27 15:33 ` James Bottomley
2009-03-27 16:14 ` Matthew Wilcox
2009-03-27 16:41 ` James Bottomley
2009-03-27 15:11 ` Matthew Wilcox
2009-03-26 20:43 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090327150940.GK8014@parisc-linux.org \
--to=matthew@wil.cx \
--cc=James.Bottomley@HansenPartnership.com \
--cc=James.Smart@Emulex.Com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.