From: Mark Brown <broonie@sirena.org.uk>
To: "Daniel Glöckner" <dg@emlix.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [patch 2/2] alsa: s6105 IP camera machine specific ASoC code
Date: Fri, 27 Mar 2009 16:39:03 +0000 [thread overview]
Message-ID: <20090327163902.GC6752@sirena.org.uk> (raw)
In-Reply-To: <49CCFFD1.7000705@emlix.com>
On Fri, Mar 27, 2009 at 05:33:21PM +0100, Daniel Glöckner wrote:
> On 03/26/2009 03:26 PM, Mark Brown wrote:
> > Are you sure you're applying the correct configuration to the correct
> > DAI here - S6105_CODEC_CLOCK is a CPU define, not a CODEC define?
> In this case S6105 was referring to the S6105 reference design. It's a machine
> define at the top of the file.
Hrm, OK.
> >> +static int snd_soc_dapm_set_endpoint(struct snd_soc_codec *codec, char *name,
> > This shouldn't be in a driver!
> I know, but it was made static in soc-dapm.c when it was renamed to
> snd_soc_dapm_set_pin.
In cases like this you should submit a patch adding the API back to the
core rather than adding a generic API as local code in your machine
driver.
next prev parent reply other threads:[~2009-03-27 16:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-26 13:36 [patch 1/2] alsa: ASoC driver for s6000 I2S interface Daniel Glöckner
2009-03-26 13:36 ` [patch 2/2] alsa: s6105 IP camera machine specific ASoC code Daniel Glöckner
2009-03-26 14:26 ` Mark Brown
2009-03-27 16:33 ` Daniel Glöckner
2009-03-27 16:39 ` Mark Brown [this message]
2009-03-26 14:15 ` [patch 1/2] alsa: ASoC driver for s6000 I2S interface Mark Brown
2009-03-27 16:09 ` Daniel Glöckner
2009-03-27 16:20 ` Mark Brown
2009-03-27 16:49 ` Daniel Glöckner
2009-03-27 16:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090327163902.GC6752@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=dg@emlix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.