From: Jean-Francois Moine <moinejf@free.fr>
To: Adam Baker <linux@baker-net.org.uk>
Cc: linux-media@vger.kernel.org, kilgota@banach.math.auburn.edu,
Hans de Goede <j.w.r.degoede@hhs.nl>,
Hans Verkuil <hverkuil@xs4all.nl>
Subject: Re: [RFC][PATCH 1/2] Sensor orientation reporting
Date: Fri, 27 Mar 2009 20:21:53 +0100 [thread overview]
Message-ID: <20090327202153.7173f48f@free.fr> (raw)
In-Reply-To: <200903152229.48761.linux@baker-net.org.uk>
On Sun, 15 Mar 2009 22:29:48 +0000
Adam Baker <linux@baker-net.org.uk> wrote:
> Add support to the SQ-905 driver to pass back to user space the
> sensor orientation information obtained from the camera during init.
> Modifies gspca and the videodev2.h header to create the necessary
> API.
>
> Signed-off-by: Adam Baker <linux@baker-net.org.uk>
>
> ---
[snip]
> diff -r 1248509d8bed linux/drivers/media/video/gspca/gspca.h
> --- a/linux/drivers/media/video/gspca/gspca.h Sat Mar 14
> 08:44:42 2009 +0100
> +++ b/linux/drivers/media/video/gspca/gspca.h Sun Mar 15
> 22:25:34 2009 +0000
> @@ -168,6 +168,7 @@ struct gspca_dev {
> __u8 alt; /* USB alternate setting */
> __u8 nbalt; /* number of USB alternate settings */
> u8 bulk; /* image transfer by 0:isoc / 1:bulk
> */
> + u32 input_flags; /* value for ENUM_INPUT status flags
> */ };
[snip]
Hi Adam,
This 'input_flags' should better go to the 'struct cam' (line 59).
Cheers.
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
next prev parent reply other threads:[~2009-03-27 19:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-15 22:24 [RFC][PATCH 0/2] Sensor orientation reporting Adam Baker
2009-03-15 22:29 ` [RFC][PATCH 1/2] " Adam Baker
2009-03-27 17:31 ` Mauro Carvalho Chehab
2009-03-27 23:36 ` Adam Baker
2009-03-27 19:21 ` Jean-Francois Moine [this message]
2009-03-15 22:34 ` [RFC][PATCH 2/2] " Adam Baker
2009-03-16 8:00 ` [RFC][PATCH 0/2] " Hans de Goede
2009-03-16 18:20 ` Theodore Kilgore
2009-03-16 23:36 ` Adam Baker
2009-03-17 8:10 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090327202153.7173f48f@free.fr \
--to=moinejf@free.fr \
--cc=hverkuil@xs4all.nl \
--cc=j.w.r.degoede@hhs.nl \
--cc=kilgota@banach.math.auburn.edu \
--cc=linux-media@vger.kernel.org \
--cc=linux@baker-net.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.