From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LnYlV-0000nX-KP for mharc-grub-devel@gnu.org; Sat, 28 Mar 2009 09:40:01 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LnYlU-0000mq-Ml for grub-devel@gnu.org; Sat, 28 Mar 2009 09:40:00 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LnYlP-0000hf-WB for grub-devel@gnu.org; Sat, 28 Mar 2009 09:40:00 -0400 Received: from [199.232.76.173] (port=55646 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LnYlP-0000hR-Qj for grub-devel@gnu.org; Sat, 28 Mar 2009 09:39:55 -0400 Received: from aybabtu.com ([69.60.117.155]:57954) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LnYlP-0003Ay-E6 for grub-devel@gnu.org; Sat, 28 Mar 2009 09:39:55 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1LnYbV-0005pJ-B5 for grub-devel@gnu.org; Sat, 28 Mar 2009 14:29:42 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1LnYlI-0002Ph-4z for grub-devel@gnu.org; Sat, 28 Mar 2009 14:39:48 +0100 Date: Sat, 28 Mar 2009 14:39:48 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090328133948.GE8493@thorin> References: <20090325.211352.91562933.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090325.211352.91562933.davem@davemloft.net> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH]: grub: Fix sparc64 setjmp implementation, update grub_setjmp() attributes. X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Mar 2009 13:40:00 -0000 On Wed, Mar 25, 2009 at 09:13:52PM -0700, David Miller wrote: > > The FSF has received my copyright assignment paperwork so I'm starting > to feed fresh copies of my sparc64 changes. > > Here, we fix the setjmp assembler implementation for sparc64 and also > we fix all of the grub_setjmp declarations to have the proper > "returns_twice" attribute. > > For normal "setjmp" GCC recognizes this special function name and > internally adds the attribute. Amongst other things this makes sure > GCC does not emit a tail-call in functions that call grub_setjmp(). > Since we use a special name for setjmp in GRUB we need to explicitly > add the attribute. > > Without this fix, GCC on sparc64 really did emit a tail-call in the > nomal module where grub_setjmp() is called, and this led to myserious > crashes :-) > > 2009-03-25 David S. Miller > > * normal/sparc64/setjmp.S: Fix setjmp implementation. > * include/grub/sparc64/setjmp.h (grub_jmp_buf): Update. > (grub_setjmp): Mark with 'returns_twice' attribute. > * include/grub/i386/setjmp.h (grub_setjmp): Likewise > * include/grub/powerpc/setjmp.h (grub_setjmp): Likewise. > * include/grub/x86_64/setjmp.h (grub_setjmp): Likewise. Hi, Unless there's someone else in the list who is knowledgeable about sparc assembly and is going to review this part of David's patch, I'm going to assume it's fine and check it in. This also goes for future patches sent by David. So if you will speak, do it now :-) -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."