From: Tony Lindgren <tony@atomide.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-arm-kernel@lists.arm.linux.org.uk, linux-omap@vger.kernel.org
Subject: Re: OMAP2 build errors
Date: Sat, 28 Mar 2009 10:35:53 -0700 [thread overview]
Message-ID: <20090328173552.GB5291@atomide.com> (raw)
In-Reply-To: <20090328124823.GB4550@n2100.arm.linux.org.uk>
* Russell King - ARM Linux <linux@arm.linux.org.uk> [090328 05:48]:
> The result of building an OMAP2 configuration for merged mainline, master
> and devel branches is:
>
> CC arch/arm/mach-omap2/devices.o
> arch/arm/mach-omap2/devices.c:160: error: ■OMAP34XX_MAILBOX_BASE■ undeclared here (not in a function)
>
> Please resolve ASAP - if I don't have a patch by this evening, I will
> commit the work-around below:
>
> diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
> index d6b4b2f..d16d880 100644
> --- a/arch/arm/mach-omap2/devices.c
> +++ b/arch/arm/mach-omap2/devices.c
> @@ -156,6 +156,7 @@ static struct resource omap2_mbox_resources[] = {
> };
>
> static struct resource omap3_mbox_resources[] = {
> +#ifdef CONFIG_ARCH_OMAP3
> {
> .start = OMAP34XX_MAILBOX_BASE,
> .end = OMAP34XX_MAILBOX_BASE + MBOX_REG_SIZE - 1,
> @@ -165,6 +166,7 @@ static struct resource omap3_mbox_resources[] = {
> .start = INT_24XX_MAIL_U0_MPU,
> .flags = IORESOURCE_IRQ,
> },
> +#endif
> };
>
> static struct platform_device mbox_device = {
Hmm, I thought I compiled all boards both against mainline and
omap-clks3. I'll check it and send a patch ASAP.
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-03-28 17:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-28 12:48 OMAP2 build errors Russell King - ARM Linux
2009-03-28 17:35 ` Tony Lindgren [this message]
2009-03-28 17:57 ` [PATCH] ARM: OMAP: Fix mailbox compile for 24xx (Re: OMAP2 build errors) Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090328173552.GB5291@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.