From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LnZZM-0007iL-1Q for mharc-grub-devel@gnu.org; Sat, 28 Mar 2009 10:31:32 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LnZZH-0007hK-MA for grub-devel@gnu.org; Sat, 28 Mar 2009 10:31:28 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LnZZE-0007g5-3H for grub-devel@gnu.org; Sat, 28 Mar 2009 10:31:26 -0400 Received: from [199.232.76.173] (port=58050 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LnZZD-0007fq-Px for grub-devel@gnu.org; Sat, 28 Mar 2009 10:31:23 -0400 Received: from mail.nexedi.com ([91.121.25.85]:49568 helo=nexedi.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LnZZD-0006Dw-EA for grub-devel@gnu.org; Sat, 28 Mar 2009 10:31:23 -0400 Received: from [10.8.0.46] (unknown [10.8.0.46]) by nexedi.com (Postfix) with ESMTP id 8BD723E0DF for ; Sat, 28 Mar 2009 15:31:18 +0100 (CET) From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Sat, 28 Mar 2009 23:31:14 +0900 User-Agent: KMail/1.9.10 References: <49C780C3.4010403@gmail.com> <20090328131306.GB8493@thorin> In-Reply-To: <20090328131306.GB8493@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200903282331.14645.okuji@enbug.org> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: multiboot on EFI X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Mar 2009 14:31:28 -0000 On Saturday 28 March 2009 22:13:06 Robert Millan wrote: > Do we need the memory map to be sorted? AFAIK loadees can cope with > unsorted maps fine; is there an exception? As I wrote in the draft, a boot loader should sort the memory map. An OS image must deal with an unsorted memory map, because the wording is "should", but it is still user-friendly (especially for debugging). > > +#ifdef GRUB_MACHINE_PCBIOS > > + grub_stop_floppy (); > > +#endif > > grub_stop_floppy() doesn't do any BIOS-specific stuff. Wouldn't __i386__ > be more appropiate? This should be moved to an arch-specific finalization function. Honestly, I prefer that this is done by disk drivers automatically when unloading, but some people seem to like giving up unloading modules. Regards, Okuji