From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LnZcK-0008Vl-08 for mharc-grub-devel@gnu.org; Sat, 28 Mar 2009 10:34:36 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LnZcH-0008Uo-OM for grub-devel@gnu.org; Sat, 28 Mar 2009 10:34:33 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LnZcG-0008UO-KH for grub-devel@gnu.org; Sat, 28 Mar 2009 10:34:32 -0400 Received: from [199.232.76.173] (port=58066 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LnZcG-0008U5-3h for grub-devel@gnu.org; Sat, 28 Mar 2009 10:34:32 -0400 Received: from mail.nexedi.com ([91.121.25.85]:49626 helo=nexedi.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LnZcF-0006hi-Nj for grub-devel@gnu.org; Sat, 28 Mar 2009 10:34:31 -0400 Received: from [10.8.0.46] (unknown [10.8.0.46]) by nexedi.com (Postfix) with ESMTP id E8F703E0DF for ; Sat, 28 Mar 2009 15:34:28 +0100 (CET) From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Sat, 28 Mar 2009 23:34:25 +0900 User-Agent: KMail/1.9.10 References: <20090325.211352.91562933.davem@davemloft.net> <20090328133948.GE8493@thorin> In-Reply-To: <20090328133948.GE8493@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200903282334.25339.okuji@enbug.org> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH]: grub: Fix sparc64 setjmp implementation, update grub_setjmp() attributes. X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Mar 2009 14:34:34 -0000 On Saturday 28 March 2009 22:39:48 Robert Millan wrote: > On Wed, Mar 25, 2009 at 09:13:52PM -0700, David Miller wrote: > > The FSF has received my copyright assignment paperwork so I'm starting > > to feed fresh copies of my sparc64 changes. > > > > Here, we fix the setjmp assembler implementation for sparc64 and also > > we fix all of the grub_setjmp declarations to have the proper > > "returns_twice" attribute. > > > > For normal "setjmp" GCC recognizes this special function name and > > internally adds the attribute. Amongst other things this makes sure > > GCC does not emit a tail-call in functions that call grub_setjmp(). > > Since we use a special name for setjmp in GRUB we need to explicitly > > add the attribute. > > > > Without this fix, GCC on sparc64 really did emit a tail-call in the > > nomal module where grub_setjmp() is called, and this led to myserious > > crashes :-) > > > > 2009-03-25 David S. Miller > > > > * normal/sparc64/setjmp.S: Fix setjmp implementation. > > * include/grub/sparc64/setjmp.h (grub_jmp_buf): Update. > > (grub_setjmp): Mark with 'returns_twice' attribute. > > * include/grub/i386/setjmp.h (grub_setjmp): Likewise > > * include/grub/powerpc/setjmp.h (grub_setjmp): Likewise. > > * include/grub/x86_64/setjmp.h (grub_setjmp): Likewise. > > Hi, > > Unless there's someone else in the list who is knowledgeable about sparc > assembly and is going to review this part of David's patch, I'm going to > assume it's fine and check it in. > > This also goes for future patches sent by David. So if you will speak, > do it now :-) I know a bit, but not that much. So I vote for that we just trust him. ;) Regards, Okuji