From: Christoph Hellwig <hch@lst.de>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] check for bs->drv in bdrv_flush
Date: Sun, 29 Mar 2009 09:31:40 +0200 [thread overview]
Message-ID: <20090329073140.GA11041@lst.de> (raw)
In-Reply-To: <49CECFB3.8010407@us.ibm.com>
On Sat, Mar 28, 2009 at 08:32:35PM -0500, Anthony Liguori wrote:
> Christoph Hellwig wrote:
> >All the bdrv_ helpers should check for bs->drv being zero as that means
> >there is no backend image open. bdrv_flush fails to perform that check
> >and can thus cause NULL pointer dereferences.
> >
> >Found using qemu-io.
> >
>
> Applied. Thanks.
>
> FWIW, I plan to include qemu-io once you rebase the series to use
> IOVectors instead of struct iovec. It looks like a useful tool!
The repost already uses QEMUIOVectors, I'll resend it with a
formal description.
prev parent reply other threads:[~2009-03-29 7:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-28 18:39 [Qemu-devel] [PATCH] check for bs->drv in bdrv_flush Christoph Hellwig
2009-03-29 1:32 ` Anthony Liguori
2009-03-29 7:31 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090329073140.GA11041@lst.de \
--to=hch@lst.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.