From: Janne Grunau <j@jannau.net>
To: linux-media@vger.kernel.org
Cc: Devin Heitmueller <devin.heitmueller@gmail.com>
Subject: [PATCH 7 of 8] au0828: remove explicitly set v4l2_device.name and unused au0828_instance
Date: Sun, 29 Mar 2009 16:59:44 +0200 [thread overview]
Message-ID: <20090329145944.GH17855@aniel> (raw)
In-Reply-To: <patchbomb.1238338474@aniel>
[-- Attachment #1: au0828_remove_v4l2_dev_name.diff --]
[-- Type: text/x-patch, Size: 1428 bytes --]
# HG changeset patch
# User Janne Grunau <j@jannau.net>
# Date 1238338428 -7200
# Node ID 9de2e49de0b75360d86b8fc444de057a485003c1
# Parent 1fd54536517a9be6f93f5711766bb8efd64ddbdf
au0828: remove explicitly set v4l2_device.name and unused au0828_instance
Priority: normal
Signed-off-by: Janne Grunau <j@jannau.net>
diff -r 1fd54536517a -r 9de2e49de0b7 linux/drivers/media/video/au0828/au0828-core.c
--- a/linux/drivers/media/video/au0828/au0828-core.c Sun Mar 29 16:53:48 2009 +0200
+++ b/linux/drivers/media/video/au0828/au0828-core.c Sun Mar 29 16:53:48 2009 +0200
@@ -37,8 +37,6 @@
module_param_named(debug, au0828_debug, int, 0644);
MODULE_PARM_DESC(debug, "enable debug messages");
-static atomic_t au0828_instance = ATOMIC_INIT(0);
-
#define _AU0828_BULKPIPE 0x03
#define _BULKPIPESIZE 0xffff
@@ -170,7 +168,7 @@
static int au0828_usb_probe(struct usb_interface *interface,
const struct usb_device_id *id)
{
- int ifnum, retval, i;
+ int ifnum, retval;
struct au0828_dev *dev;
struct usb_device *usbdev = interface_to_usbdev(interface);
@@ -198,9 +196,6 @@
usb_set_intfdata(interface, dev);
/* Create the v4l2_device */
- i = atomic_inc_return(&au0828_instance) - 1;
- snprintf(dev->v4l2_dev.name, sizeof(dev->v4l2_dev.name), "%s-%03d",
- "au0828", i);
retval = v4l2_device_register(&interface->dev, &dev->v4l2_dev);
if (retval) {
printk(KERN_ERR "%s() v4l2_device_register failed\n",
next prev parent reply other threads:[~2009-03-29 15:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <patchbomb.1238338474@aniel>
2009-03-29 14:57 ` [PATCH 1 of 8] v4l: use usb_interface for v4l2_device_register Janne Grunau
2009-03-29 14:58 ` [PATCH 2 of 8] cx231xx: use usb_interface.dev " Janne Grunau
2009-03-29 14:58 ` [PATCH 3 of 8] cx231xx: remove explicitly set v4l2_device.name Janne Grunau
2009-03-29 14:58 ` [PATCH 4 of 8] usbvision: use usb_interface.dev for v4l2_device_register Janne Grunau
2009-03-29 14:59 ` [PATCH 5 of 8] pvrusb2: " Janne Grunau
2009-04-01 2:02 ` Mike Isely
2009-04-01 9:37 ` Mauro Carvalho Chehab
2009-04-01 11:13 ` Janne Grunau
2009-03-29 14:59 ` [PATCH 6 of 8] au0828: " Janne Grunau
2009-03-29 14:59 ` Janne Grunau [this message]
2009-03-29 14:59 ` [PATCH 8 of 8] w9968cf: " Janne Grunau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090329145944.GH17855@aniel \
--to=j@jannau.net \
--cc=devin.heitmueller@gmail.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.