From: Janne Grunau <j@jannau.net>
To: Devin Heitmueller <devin.heitmueller@gmail.com>
Cc: linux-media@vger.kernel.org, Steven Toth <stoth@linuxtv.org>
Subject: Re: [PATCH 5 of 6] au0828: use usb_interface.dev for v4l2_device_register
Date: Sun, 29 Mar 2009 17:04:31 +0200 [thread overview]
Message-ID: <20090329150431.GJ17855@aniel> (raw)
In-Reply-To: <412bdbff0903290644s3c70d5e7rfd4182f55650ead0@mail.gmail.com>
Hi Devin,
On Sun, Mar 29, 2009 at 09:44:25AM -0400, Devin Heitmueller wrote:
> On Sun, Mar 29, 2009 at 8:42 AM, Janne Grunau <j@jannau.net> wrote:
> >
>
> I'm not against this change, but you should also get rid of the "i"
> variable and the au0828_instance list (since the v4l2_device.name was
> the only purpose for both).
done
> Also, your subject didn't really match the function of the patch. Had
> I not looked at the patch itself, I would have only thought you were
> changing the v4l2_device_register().
yeah, the subject was bad for au0828 and cx231xx but I had trouble to
find find something better. I splitted the patches nao.
> Please put me on the CC: for anything related to au0828 analog
> support, since I authored the code in question.
noted, Sorry I had only looked at the au0228-core.c header which notes
only Steven.
Janne
next prev parent reply other threads:[~2009-03-29 15:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <patchbomb.1238329154@aniel>
2009-03-29 12:37 ` [PATCH 1 of 6] v4l: use usb_interface for v4l2_device_register Janne Grunau
2009-03-29 12:40 ` [PATCH 2 of 6] cx321xx: use usb_interface.dev " Janne Grunau
2009-03-29 12:41 ` [PATCH 3 of 6] usbvision: " Janne Grunau
2009-03-29 12:42 ` [PATCH 4 of 6] pvrusb2: " Janne Grunau
2009-03-29 12:42 ` [PATCH 5 of 6] au0828: " Janne Grunau
2009-03-29 13:44 ` Devin Heitmueller
2009-03-29 15:04 ` Janne Grunau [this message]
2009-03-29 12:43 ` [PATCH 6 of 6] w9968cf: " Janne Grunau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090329150431.GJ17855@aniel \
--to=j@jannau.net \
--cc=devin.heitmueller@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=stoth@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.