Re: fault.c cleanup, what else could it be

[Al Viro <viro@ZenIV.linux.org.uk>]

On Mon, Mar 30, 2009 at 01:24:22AM +0200, Ingo Molnar wrote:
> 
> * Alexey Dobriyan <adobriyan@gmail.com> wrote:
> 
> > I have personally stopped sending anything against pure arch/x86/ 
> > if there is even a smallest chance it can be prettyfied like this.
> 
> Before you volunteer reviewing x86 code for us (thanks for that!), 
> may i direct your urgent attention at code in your own area of 
> responsibility - such as fs/proc/base.c:
> 
>     total: 85 errors, 39 warnings, 2 checks, 3147 lines checked
> 
> I filtered out the relevant ones for you below.

This is precisely what's wrong with your advocacy.  I actually have no
problem with specific instances pointed to by checkpatch.pl in this case;
when code in question gets touched, sure, getting rid of those would be OK.
*HOWEVER*, implying that this noise should take priority over any real work
is bloody insane.  And replying to mail that questions the usefulness of
such activity with "shut up, do what you've pretty much called pointless
and don't come back until you are done"... fie, sir.