From: Jean Delvare <jdelvare@suse.de>
To: Chris Wright <chrisw@sous-sol.org>
Cc: stable@kernel.org, Mike Christie <michaelc@cs.wisc.edu>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] libsrp: free kfifo struct in srp_iu_pool_free
Date: Mon, 30 Mar 2009 21:38:01 +0200 [thread overview]
Message-ID: <200903302138.02155.jdelvare@suse.de> (raw)
In-Reply-To: <20090330184901.GC11116@hera.kernel.org>
Hi Chris,
Le lundi 30 mars 2009, Chris Wright a écrit :
> Appears to be a small leak here when freeing pool, the kfifo gets left
> behind. Did I miss a caller that frees kfifo?
>
> Signed-off-by: Chris Wright <chrisw@sous-sol.org>
> ---
> diff --git a/drivers/scsi/libsrp.c b/drivers/scsi/libsrp.c
> index 15e2d13..3a305f8 100644
> --- a/drivers/scsi/libsrp.c
> +++ b/drivers/scsi/libsrp.c
> @@ -81,6 +81,7 @@ static void srp_iu_pool_free(struct srp_queue *q)
> {
> kfree(q->items);
> kfree(q->pool);
> + kfree(q->queue);
> }
>
> static struct srp_buf **srp_ring_alloc(struct device *dev,
>
You appear to be correct, I can't see q->queue being freed anywhere
either.
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
Suse L3
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-03-30 19:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200903291119.42080.jdelvare@suse.de>
2009-03-30 18:44 ` [stable] [PATCH] [SCSI] libiscsi: fix iscsi pool error path Chris Wright
2009-03-30 18:49 ` [PATCH] libsrp: free kfifo struct in srp_iu_pool_free Chris Wright
2009-03-30 19:38 ` Jean Delvare [this message]
2009-03-30 19:34 ` [stable] [PATCH] [SCSI] libiscsi: fix iscsi pool error path Jean Delvare
2009-03-30 19:43 ` Chris Wright
2009-03-31 6:38 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903302138.02155.jdelvare@suse.de \
--to=jdelvare@suse.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=chrisw@sous-sol.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.