All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Tso <tytso@mit.edu>
To: "J.D. Bakker" <jdb@lartmaker.nl>
Cc: linux-ext4@vger.kernel.org
Subject: Re: Once more: Recovering a damaged ext4 fs?
Date: Tue, 31 Mar 2009 08:42:04 -0400	[thread overview]
Message-ID: <20090331124204.GF13356@mit.edu> (raw)
In-Reply-To: <p062405b1c5f59a4c5ed1@[130.161.115.44]>

OK, here's a patch that should allow mke2fs -S to work.  It should be
applied against the e2fsprogs 1.41.4.

Sorry for the delay in getting this to you; things have been crazy
busy on my end.

						- Ted

commit a620baddee647faf42c49ee2e04ee3f667149d68
Author: Theodore Ts'o <tytso@mit.edu>
Date:   Tue Mar 31 07:42:24 2009 -0400

    mke2fs: Don't try to create the journal in super-only mode
    
    Since we aren't initializing the inode table, creating the journal
    will just fail.
    
    Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>

diff --git a/misc/mke2fs.c b/misc/mke2fs.c
index e69e5ce..4f50ffa 100644
--- a/misc/mke2fs.c
+++ b/misc/mke2fs.c
@@ -2079,6 +2079,12 @@ int main (int argc, char *argv[])
 		    EXT3_FEATURE_COMPAT_HAS_JOURNAL)) {
 		journal_blocks = figure_journal_size(journal_size, fs);
 
+		if (super_only) {
+			printf(_("Skipping journal creation in super-only mode\n"));
+			fs->super->s_journal_inum = EXT2_JOURNAL_INO;
+			goto no_journal;
+		}
+
 		if (!journal_blocks) {
 			fs->super->s_feature_compat &=
 				~EXT3_FEATURE_COMPAT_HAS_JOURNAL;

      reply	other threads:[~2009-03-31 12:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-27 20:41 Once more: Recovering a damaged ext4 fs? J.D. Bakker
2009-03-27 22:46 ` Theodore Tso
2009-03-27 23:47   ` J.D. Bakker
2009-03-28  4:06     ` Theodore Tso
2009-03-28 12:30     ` Theodore Tso
2009-03-28 12:53       ` J.D. Bakker
2009-03-28 13:09         ` Theodore Tso
2009-03-29 22:01           ` J.D. Bakker
2009-03-31 12:42             ` Theodore Tso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090331124204.GF13356@mit.edu \
    --to=tytso@mit.edu \
    --cc=jdb@lartmaker.nl \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.