Re: [PATCH 3/4] ARM: OMAP3: Add support for 3430 SDP, v3

[Tony Lindgren <tony@atomide.com>]

[-- Attachment #1: Type: text/plain, Size: 1649 bytes --]

* Gadiyar, Anand <gadiyar@ti.com> [090331 06:38]:
> > > * Tony Lindgren <tony@atomide.com> [090316 11:14]:
> > > > * Russell King - ARM Linux <linux@arm.linux.org.uk> [090315 08:48]:
> > > > > On Sun, Mar 15, 2009 at 03:47:01PM +0000, Russell King - ARM Linux wrote:
> > > > > > On Fri, Mar 13, 2009 at 03:47:26PM -0700, Tony Lindgren wrote:
> > > > > > > +#include <mach/mcspi.h>
> > > > > > > +#include <mach/gpio.h>
> > > > > > 
> > > > > > Shouldn't this be linux/gpio.h ?
> > > > > 
> > > > > Note that Syed Mohammed Khasim <x0khasim@ti.com> address is not valid.
> > > > 
> > > > Thanks, updated patch below.
> > > 
> > > Oops, forgot to run stg refresh before sending out this, v3 below
> > > 
> > > Tony
> > > 
> > 
> > Tony, Russell,
> > 
> > Sorry for not catching this before it got merged.
> > 
> > I could not run the 3430 SDP defconfig from mainline. The image hangs at
> > "Starting kernel ...". Enabling CONFIG_DEBUG_LL does not help.
> >  
> > The omap_3430sdp_defconfig seems to have too many differences from the
> > defconfigs for other OMAP3 boards. In fact, it's not even similar to the
> > file present in the linux-omap tree.
> > 
> > So I took the SDP defconfig from the l-o tree and replaced the one on
> > mainline with it. And we have a compile break in a display file. Removing
> > CONFIG_FB_OMAP works around the compile break.
> > 
> > Please consider merging this patch (l-o SDP defconfig minus CONFIG_FB_OMAP)
> > so that we can finally use an SDP with mainline.
> > 
> 
> 
> Oops. Now, this doesn't work for me either. Sorry for the noise.

What do you get with CONFIG_DEBUG_LL and the attached hack applied?

Tony

[-- Attachment #2: debug-ll.hack --]
[-- Type: text/plain, Size: 674 bytes --]

--- a/kernel/printk.c
+++ b/kernel/printk.c
@@ -44,6 +44,10 @@ void asmlinkage __attribute__((weak)) early_printk(const char *fmt, ...)
 
 #define __LOG_BUF_LEN	(1 << CONFIG_LOG_BUF_SHIFT)
 
+#ifdef CONFIG_DEBUG_LL
+extern void printascii(char *);
+#endif
+
 /* printk's without a loglevel use this.. */
 #define DEFAULT_MESSAGE_LOGLEVEL 4 /* KERN_WARNING */
 
@@ -667,6 +671,9 @@ asmlinkage int vprintk(const char *fmt, va_list args)
 	printed_len += vscnprintf(printk_buf + printed_len,
 				  sizeof(printk_buf) - printed_len, fmt, args);
 
+#ifdef	CONFIG_DEBUG_LL
+	printascii(printk_buf);
+#endif
 
 	/*
 	 * Copy the output into log_buf.  If the caller didn't provide

[-- Attachment #3: Type: text/plain, Size: 271 bytes --]

-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php