All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Markus Metzger <markus.t.metzger@intel.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, tglx@linutronix.de,
	hpa@zytor.com, markus.t.metzger@gmail.com, roland@redhat.com,
	eranian@googlemail.com, juan.villacis@intel.com,
	ak@linux.jf.intel.com
Subject: Re: [patch 4/21] mm: refund memory for a locked buffer
Date: Wed, 1 Apr 2009 02:23:34 +0200	[thread overview]
Message-ID: <20090401002334.GD28228@redhat.com> (raw)
In-Reply-To: <20090331150319.A12691@sedona.ch.intel.com>

On 03/31, Markus Metzger wrote:
>
> -void release_locked_buffer(void *buffer, size_t size)
> +void refund_locked_buffer_memory(struct mm_struct *mm, size_t size)

Hmm. Again, this is not bisect friendly, afaoics the kernel can't be
compiled with this patch. Irenames release_locked_buffer(), but we still
have callers (fixed by the next patches).

>  void free_locked_buffer(void *buffer, size_t size)
>  {
> -	release_locked_buffer(buffer, size);
> -
> +	refund_locked_buffer_memory(current->mm, size);
>  	kfree(buffer);
>  }

And this one has no callers after the next patches?

Oleg.


      reply	other threads:[~2009-04-01  0:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-31 13:03 [patch 4/21] mm: refund memory for a locked buffer Markus Metzger
2009-04-01  0:23 ` Oleg Nesterov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090401002334.GD28228@redhat.com \
    --to=oleg@redhat.com \
    --cc=ak@linux.jf.intel.com \
    --cc=eranian@googlemail.com \
    --cc=hpa@zytor.com \
    --cc=juan.villacis@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus.t.metzger@gmail.com \
    --cc=markus.t.metzger@intel.com \
    --cc=mingo@elte.hu \
    --cc=roland@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.