From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH] Fixes for build/install system Date: Wed, 1 Apr 2009 08:44:39 +0100 Message-ID: <200904010944.39425.Christoph.Egger@amd.com> References: <200903311422.14692.Christoph.Egger@amd.com> <18898.16577.474687.221544@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <18898.16577.474687.221544@mariner.uk.xensource.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: "xen-devel@lists.xensource.com" , Keir Fraser List-Id: xen-devel@lists.xenproject.org On Tuesday 31 March 2009 18:11:45 Ian Jackson wrote: > Christoph Egger writes ("[PATCH] Fixes for build/install system"): > > Attached patches get rid of hardcoded install path, > > fixes wrong install paths and replaces mkdir -p with $(INSTALL_DIR). > > All in all, a command like PREFIX="/usr/local" gmake dist > > now installs everything into dist/install/usr/local > > instead of dist/install/usr > > This is all very nice but > > > install-doc: $(DOCS) > > - mkdir -p "$(DESTDIR)$(docdir)" > > + $(INSTALL_DIR) "$(DESTDIR)$(docdir)" > > $(INSTALL) -m 644 qemu-doc.html qemu-tech.html "$(DESTDIR)$(docdir)" > > these are parts of the Makefile which come from upstream qemu. > I definitely don't want to modify those parts. Everything which is > done in the makefiles in qemu-xen-unstable is aimed at avoiding large > textual changes which make merging difficult. We don't want changes > in our versions of the upstream makefiles which are not absolutely > necessary to make things work. > > It's not clear to me by inspection whether I can safely apply the > other parts of your qemu patch on their own. Can you confirm ? Yes, I can confirm. It is just less consistent throughout the whole xen build/install system. Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632